Review request for JDK-8026021: more fix of javadoc errors and warnings reported by doclint

Hi, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8026021 more fix of javadoc errors and warnings reported by doclint, see the description webrev: http://cr.openjdk.java.net/~cl/8026021/webrev.00/ Thanks Christine

hg: jdk8/awt/jdk: 8025840: Fix all the doclint warnings about trademark

Changeset: 546c0ebfbf56 Author:cl Date: 2013-10-07 11:34 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/546c0ebfbf56 8025840: Fix all the doclint warnings about trademark Reviewed-by: art ! src/share/classes/javax/swing/AbstractAction.java ! src/share/classes/javax/swing/Ab

Re: Review request for JDK-8025840: Fix all the doclint warnings about trademark

Artem, Yes, there are warnings about it, in the same report as those trademark warnings in http://rehudson.us.oracle.com:8080/hudson/job/christine/lastSuccessfulBuild/artifact/client-doclint-html/javax_swing-accessibility.txt /tmp/workspace/christine-2-solaris-i586/jdk8-awt/382/jdk/src/share/c

[8] Review request for 7172597: java.awt.KeyboardFocusManager.clearFocusOwner() missed javadoc tag @since 1.8

Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/7172597.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-7172597 Added missed tag @since 1.8 Thanks, SAM

[8] Review Request: 8022119 test api/javax_sound/sampled/spi/MixerProvider/indexTGF_MixerProviderTests fails

Hello. Please review the fix for jdk 8. ServiceLoader usage was changed according to the change in JDK-8019622 Bug: https://bugs.openjdk.java.net/browse/JDK-8022119 Webrev can be found at: http://cr.openjdk.java.net/~serb/8022119/webrev.00 -- Best regards, Sergey.

Re: [8] Review request for 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified

Hello. I agree that it is a good time to make cleanup of all strange code that we have. We will have enough time to catch regression. On 04.10.2013 15:37, Anthony Petrov wrote: On 10/04/2013 02:57 PM, Artem Ananiev wrote: On 10/4/2013 2:45 PM, Anthony Petrov wrote: On 10/02/2013 05:07 PM, Ar

Re: [8] Request for review: 8025603 Unused methods in the awt text peers should be removed

Nice cleanup, now looks fine. Let us see what will be broken, as it usually happens with most of cleanups :) Thanks, Artem On 10/7/2013 7:19 PM, Sergey Bylokhov wrote: Hi, Artem. Thanks for review. Updated version: http://cr.openjdk.java.net/~serb/8025603/webrev.01 WComponentPeer.minimumSi

Re: [8] Request for review: 8025603 Unused methods in the awt text peers should be removed

Hi, Artem. Thanks for review. Updated version: http://cr.openjdk.java.net/~serb/8025603/webrev.01 WComponentPeer.minimumSize also removed, because it is never used in java or in native. On 07.10.2013 18:03, Artem Ananiev wrote: Hi, Sergey, the changes look fine. Could you also remove deprec

Re: [8] Review request for 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified

On 10/4/2013 3:37 PM, Anthony Petrov wrote: On 10/04/2013 02:57 PM, Artem Ananiev wrote: On 10/4/2013 2:45 PM, Anthony Petrov wrote: On 10/02/2013 05:07 PM, Artem Ananiev wrote: You're right, it's not necessary. However, since we touch this code anyway, I'd be glad to have this redundant code

Re: [8] Request for review: 8025603 Unused methods in the awt text peers should be removed

Hi, Sergey, the changes look fine. Could you also remove deprecated methods in WTextArea, e.g. insertText(), since you touch these files anyway, please? Thanks, Artem On 10/2/2013 10:38 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. This is a code cleanup. Bug: https:/

Re: [8] Review request for 7199196: Incremental transfer is broken because of a typo

Looks fine. -- best regards, Anthony On 10/04/13 21:08, Oleg Pekhovskiy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/7199196.1/ for https://bugs.openjdk.java.net/browse/JDK-7199196 Just a typo fix. Thanks, Oleg

hg: jdk8/awt/jdk: 8007219: [macosx] Frame size reverts meaning of maximized attribute if frame size close to display

Changeset: 72afa269fa3b Author:alexsch Date: 2013-10-07 16:42 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/72afa269fa3b 8007219: [macosx] Frame size reverts meaning of maximized attribute if frame size close to display Reviewed-by: serb, anthony ! src/macosx/classes/sun/

hg: jdk8/awt/jdk: 8025438: [macosx] right JNFCall* method should be used in JDK-8008728 fix

Changeset: 01b40315f872 Author:alexsch Date: 2013-10-07 16:13 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/01b40315f872 8025438: [macosx] right JNFCall* method should be used in JDK-8008728 fix Reviewed-by: serb, anthony ! src/macosx/native/sun/awt/AWTWindow.m

Re: [8] Review request for 8016356: Any swing frame resizes ugly.

Hi, Oleg, could you provide information (here and in bug comments), what are the values returned by GetWindowRect() and getWindowPlacement(), while the window is being snapped and after it has been snapped, please? Thanks, Artem On 10/7/2013 2:17 PM, Oleg Pekhovskiy wrote: Hi All, Please

Re: Review request for JDK-8025840: Fix all the doclint warnings about trademark

Hi, Christine, trademark changes look fine. What's wrong with the table in BoxLayout.java? Were there any warnings reported about it? Thanks, Artem On 10/5/2013 4:08 AM, christine...@oracle.com wrote: Hi, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8025840 Fix all th

Re: [8] Review request for 8016356: Any swing frame resizes ugly.

Hi All, Please review the second version of fix http://cr.openjdk.java.net/~bagiras/8016356.2/ for http://bugs.sun.com/view_bug.do?bug_id=8016356 I found quite robust way to determine Windows Snap-feature that relies upon the difference between the real (GetWindowRect()) and the normal placeme