hg: jdk8/awt/jdk: 7058662: AiffFileReader throws java.lang.ArithmeticException: division by zero when frame size is zero; ...

Changeset: 81ea6299230a Author:serb Date: 2013-10-10 02:35 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/81ea6299230a 7058662: AiffFileReader throws java.lang.ArithmeticException: division by zero when frame size is zero 7058666: Unexpected exception in AU parser code 7058

hg: jdk8/awt/jdk: 8026021: more fix of javadoc errors and warnings reported by doclint, see the description

Changeset: cea6ca16142e Author:cl Date: 2013-10-09 14:32 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cea6ca16142e 8026021: more fix of javadoc errors and warnings reported by doclint, see the description Reviewed-by: anthony, serb ! src/share/classes/java/awt/GraphicsDe

[8] Review request for JDK-8026071 - Fix raw warnings in java AWT geometry package

Hi team , could someone review the fix Bug : https://bugs.openjdk.java.net/browse/JDK-8026071 Webrev : https://github.com/srikalyc/JDKfixes/blob/master/java.awt.geom.raw.webrev.zip Fix : Raw warnings in AWT geom classes fixed *NOTE*: In java.awt.geom.Area.java , the inner

Re: [8] Review request for JDK-8025684 - Fix Raw and unchecked warnings java.awt.image classes

Hi Artem, i have done some changes (more redundant casts identified and removed), please get the webrev from the same location again . Thanks for your review. --- Thanks kalyan On 10/2/2013 3:02 AM, Artem Ananiev wrote: > > java.awt.image is one of the Java2D packages, so I'm adding 2d-dev to > C

Re: [8] Review request for JDK-8022185 - JDK8 Fix Raw and unchecked warnings in classes belonging to java.awt.datatransfer

Thanks Artem, i have done the fixes, you can find the updated webrev at the same location . --- Thanks kalyan On 10/9/2013 3:12 AM, Artem Ananiev wrote: > > I put the updated webrev here: > > ht

Re: [8] Review Request: JDK-8026143 [macosx] Maximized state could be inconsistent between peer and frame

Hi, Petr. Is it possible to track this state in the deliverMoveResizeEvent? and update the state of the frame accordingly? On 09.10.2013 20:45, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8026143 The fix is available at: h

Re: [8] Review Request: JDK-8026143 [macosx] Maximized state could be inconsistent between peer and frame

Hi Petr, src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java: 577 if (!wasMaximized && isMaximized()) { 578 deliverZoom(true); 579 } else if (target instanceof Frame) { And other occurrences of deliverZoom: it looks like we call it for any CPlat

hg: jdk8/awt/jdk: 8016551: JMenuItem in WindowsLookAndFeel can't paint default icons

Changeset: fba62451d705 Author:leonidr Date: 2013-10-09 21:15 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/fba62451d705 8016551: JMenuItem in WindowsLookAndFeel can't paint default icons Reviewed-by: alexsch, serb ! src/share/classes/com/sun/java/swing/plaf/windows/Window

hg: jdk8/awt/jdk: 8019623: Lack of synchronization in AppContext.getAppContext()

Changeset: 976e5f580124 Author:leonidr Date: 2013-10-09 20:59 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/976e5f580124 8019623: Lack of synchronization in AppContext.getAppContext() Reviewed-by: anthony, art ! src/share/classes/sun/awt/AppContext.java + test/sun/awt/AppC

[8] Review Request: JDK-8026143 [macosx] Maximized state could be inconsistent between peer and frame

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8026143 The fix is available at: http://cr.openjdk.java.net/~pchelko/8026143/webrev.00/ When the window is created and it's size is bigger/equal to the size of the screen, Cocoa implicitly sets the nat

Re: [8] Review request for 8019623: Lack of synchronization in AppContext.getAppContext()

On 10/9/2013 4:32 PM, Leonid Romanov wrote: Ok, here an updated webrev then, with the test added: http://cr.openjdk.java.net/~leonidr/8019623/webrev.01/ The test looks fine, but NUM_TRIES is redundant: after the first run, mainAppContext is initialized, so it doesn't make sense to keep testi

Re: [8] Review Request: JDK-8025588 [macosx] Frozen AppKit thread in 7u40

On 10/9/2013 2:48 PM, Petr Pchelko wrote: Hello, Anthony. 1. Can InvocationEvent.notifier be final instead of volatile? It's protected, so it's a part of the public API. It is extremely unlikely someone would be broken by making this field final, but who knows.. 2. InvocationEvent now has

Re: [8] Review request for 8019623: Lack of synchronization in AppContext.getAppContext()

Quite unusual to start a name of a class (or a variable) with a verb ("GetAppContextLock"), but otherwise the fix looks fine to me. -- best regards, Anthony On 10/09/2013 04:32 PM, Leonid Romanov wrote: Ok, here an updated webrev then, with the test added: http://cr.openjdk.java.net/~leonidr/

Re: [8] Review request for 8019623: Lack of synchronization in AppContext.getAppContext()

Ok, here an updated webrev then, with the test added: http://cr.openjdk.java.net/~leonidr/8019623/webrev.01/ On Oct 8, 2013, at 7:43 PM, Artem Ananiev wrote: > > On 10/8/2013 6:54 PM, Leonid Romanov wrote: >> Hi, >> I tried different variations of your suggestion and none of them worked. The

hg: jdk8/awt/jdk: 7159266: [macosx] ApplicationDelegate should not be set in the headless mode

Changeset: 929dc0915f8c Author:anthony Date: 2013-10-09 15:34 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/929dc0915f8c 7159266: [macosx] ApplicationDelegate should not be set in the headless mode Summary: Don't install ApplicationDelegate in headless mode Reviewed-by: art

Re: [8] Review Request: JDK-8025588 [macosx] Frozen AppKit thread in 7u40

Hi Petr, The fix looks fine to me. -- best regards, Anthony On 10/09/2013 03:31 PM, Petr Pchelko wrote: Hello. Thank you for the review, but I have a new version. http://cr.openjdk.java.net/~pchelko/8025588/webrev.02/ In LWCToolkit we never throw an InterruptedException, so I've removed it f

Re: [8] Review Request: JDK-8025588 [macosx] Frozen AppKit thread in 7u40

Hi, Petr. New version looks good as well. On 09.10.2013 15:31, Petr Pchelko wrote: Hello. Thank you for the review, but I have a new version. http://cr.openjdk.java.net/~pchelko/8025588/webrev.02/ In LWCToolkit we never throw an InterruptedException, so I've removed it from the method signatu

Re: javax.swing.RepaintManager volatileMap

Hi, Vladimir, have you received this reply, or it was lost for some reason? Thanks, Artem On 8/28/2013 5:52 PM, Artem Ananiev wrote: Hi, Vladimir, I agree that using a class with no equals/hashCode overridden as a key for HashMap is not the best thing to do. However, in this case the problem

Re: [8] Review Request: JDK-8025588 [macosx] Frozen AppKit thread in 7u40

Hello. Thank you for the review, but I have a new version. http://cr.openjdk.java.net/~pchelko/8025588/webrev.02/ In LWCToolkit we never throw an InterruptedException, so I've removed it from the method signature. But I forgot to remove it from the catch clauses in the places where the method i

Re: [8] Review request for 7159266: [macosx] ApplicationDelegate should not be set in the headless mode

Hi, Anthony. The fix looks good. On 09.10.2013 12:50, Anthony Petrov wrote: Hello, This is a reminder. -- best regards, Anthony On 10/04/2013 03:11 PM, Anthony Petrov wrote: Hello, This is another forward-port (a direct one this time) that didn't make it into JDK 8 yet: bug: https://bugs.o

Re: [8] Review Request: JDK-8025588 [macosx] Frozen AppKit thread in 7u40

Hi, Petr. The fix looks good. On 09.10.2013 14:48, Petr Pchelko wrote: Hello, Anthony. 1. Can InvocationEvent.notifier be final instead of volatile? It's protected, so it's a part of the public API. It is extremely unlikely someone would be broken by making this field final, but who knows..

Re: [8] Review Request: JDK-8025588 [macosx] Frozen AppKit thread in 7u40

Hello, Anthony. > 1. Can InvocationEvent.notifier be final instead of volatile? It's protected, so it's a part of the public API. It is extremely unlikely someone would be broken by making this field final, but who knows.. > 2. InvocationEvent now has 4 ctors, 3 public and 1 private. Can all the

Re: [8] Review Request: JDK-8025588 [macosx] Frozen AppKit thread in 7u40

Hi, Petr, a few comments: 1. Can InvocationEvent.notifier be final instead of volatile? 2. InvocationEvent now has 4 ctors, 3 public and 1 private. Can all the public ctors call the private one directly? Right now there is an extra call from one public ctor to another, which then call the pri

Re: [8] Review request for 7159266: [macosx] ApplicationDelegate should not be set in the headless mode

Looks fine. Thanks, Artem On 10/9/2013 12:50 PM, Anthony Petrov wrote: Hello, This is a reminder. -- best regards, Anthony On 10/04/2013 03:11 PM, Anthony Petrov wrote: Hello, This is another forward-port (a direct one this time) that didn't make it into JDK 8 yet: bug: https://bugs.ope

hg: jdk8/awt/jdk: 8016356: Any swing frame resizes ugly.

Changeset: 84c766f6796b Author:bagiras Date: 2013-10-09 14:12 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/84c766f6796b 8016356: Any swing frame resizes ugly. Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_Window.cpp

Re: [8] Review request for JDK-8022185 - JDK8 Fix Raw and unchecked warnings in classes belonging to java.awt.datatransfer

I put the updated webrev here: http://cr.openjdk.java.net/~art/srikalyc/8022185.01/ A few comments: 1. DataFlavor.java: some of the lines got too long after the fix. Please, reformat or add import statements. 2. DataFlavor.java: there are some redundant class casts left, e.g. at line #334.

Re: [8] Review request for 8016356: Any swing frame resizes ugly.

Looks fine. Thanks, Artem On 10/8/2013 9:14 PM, Oleg Pekhovskiy wrote: Hi Artem, Anthony, thank you for the review... I've added more details in the source code comments and bug comments, plus changed "else" location. Please review the next version of fix: http://cr.openjdk.java.net/~bagir

hg: jdk8/awt/jdk: 8025649: need test to cover JDK-8000423

Changeset: 2e59014ef38f Author:alexsch Date: 2013-10-09 13:40 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2e59014ef38f 8025649: need test to cover JDK-8000423 Reviewed-by: anthony, serb Contributed-by: Alexander Stepanov + test/java/awt/InputMethods/DiacriticsTest/Diacr

[8] Review Request: JDK-8025588 [macosx] Frozen AppKit thread in 7u40

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8025588 The fix is available at: http://cr.openjdk.java.net/~pchelko/8025588/webrev.00/ The CCC request for public API changes was approved: http://ccc.us.oracle.com/8025588 The problem: Is some cases I

Re: [8] Review request for 7159266: [macosx] ApplicationDelegate should not be set in the headless mode

Hello, This is a reminder. -- best regards, Anthony On 10/04/2013 03:11 PM, Anthony Petrov wrote: Hello, This is another forward-port (a direct one this time) that didn't make it into JDK 8 yet: bug: https://bugs.openjdk.java.net/browse/JDK-2224144 webrev: http://cr.openjdk.java.net/~anthony

Re: Review request for JDK-8026021: more fix of javadoc errors and warnings reported by doclint

Thanks for the comments and the corrections, Christine. The updated webrev looks fine to me. -- best regards, Anthony On 10/09/2013 12:57 AM, christine...@oracle.com wrote: Thank you all for reviewing. I have posted a new webrev at http://cr.openjdk.java.net/~cl/8026021/webrev.01