hg: jdk8/awt/jdk: 8027628: JWindow jumps to (0, 0) after mouse clicked

Changeset: 3ee121726c17 Author:bagiras Date: 2013-11-18 23:24 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3ee121726c17 8027628: JWindow jumps to (0, 0) after mouse clicked Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/clas

hg: jdk8/awt/jdk: 8027992: FileInputStream and BufferedInputStream should be closed in sun.applet.*

Changeset: 919562e54af8 Author:pchelko Date: 2013-11-18 19:22 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/919562e54af8 8027992: FileInputStream and BufferedInputStream should be closed in sun.applet.* Reviewed-by: anthony, serb ! src/share/classes/sun/applet/AppletPanel

Re: [8] Review request for 8027628: JWindow jumps to (0, 0) after mouse clicked

Hi Oleg, Thank you for the additional investigation. The updated fix looks fine to me. To answer your question: Does it make sense to perform such testing if I made functionality changes in XWindowPeer.java only? Well, the fix could still hurt the performance for heavyweight popup menus.

Re: Review Request: JDK-8027992 FileInputStream and BufferedInputStream should be closed in sun.applet.*

Still looks fine. -- best regards, Anthony On 11/18/2013 10:58 AM, Petr Pchelko wrote: Hello, Please have a look on an updated version of the fix: http://cr.openjdk.java.net/~pchelko/8027992/webrev.01/ According to Sergey's offline comment I've use a better pattern for try-with-resources wit

Re: [8] Review Request: 8027913 drop target notifications are sent out of order during DnD

The fix looks good to me as well. -- best regards, Anthony On 11/18/2013 05:57 PM, Sergey Bylokhov wrote: After executing of the test from the fix on different platforms I found other problems in dnd. - On windows the nested event loop sometimes is not stopped if the window was disposed befor

Re: [8] Review Request: 8027913 drop target notifications are sent out of order during DnD

After executing of the test from the fix on different platforms I found other problems in dnd. - On windows the nested event loop sometimes is not stopped if the window was disposed before than dnd events was dispatched. - On linux mouse_exit event is not fired, but everything is ok for mouse_

Re: [8] Review request for 8028271: Wrong alt processing during switching between windows.

Hi, Mikhail. This test gets an access to the swing components incorrectly on non-edt thread. On 15.11.2013 21:12, mikhail cherkasov wrote: Hi all, This is a small fix of a test : http://cr.openjdk.java.net/~mcherkas/8028271/webrev.00/

Re: [8] Review request for 8027628: JWindow jumps to (0, 0) after mouse clicked

Hi, Oleg. The fix looks good. On 15.11.2013 19:35, Oleg Pekhovskiy wrote: Hi Anthony, thank you for the review, the second version of fix is here: http://cr.openjdk.java.net/~bagiras/8027628.2/ Brief: 1. XBaseWindow changes were reverted. 2. Shared code moved from XDecoratedPeer to XWindowPee

Re: Review Request: JDK-8027992 FileInputStream and BufferedInputStream should be closed in sun.applet.*

Hi, Petr. The fix looks good. On 18.11.2013 10:58, Petr Pchelko wrote: Hello, Please have a look on an updated version of the fix: http://cr.openjdk.java.net/~pchelko/8027992/webrev.01/ According to Sergey's offline comment I've use a better pattern for try-with-resources with wrapped streams

Re: [8] Review Request: 8027913 drop target notifications are sent out of order during DnD

Hi, Sergey, the fix looks fine in general. I would just propose an alternative naming: instead of "mouseDTEnterExit" use "dropTargetEnterExit". Thanks, Artem On 11/14/2013 7:31 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 8. The problem was in the missing notification abo