Changeset: f99277913d40
Author:pchelko
Date: 2013-11-27 11:41 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f99277913d40
8011142: [TEST_BUG] 2 AppContext regression tests failed since 7u25b03 with
NullPointerException
Reviewed-by: anthony, serb
! test/java/awt/EventQueue/
HI, Volker.
Thanks for clarification. The fix looks good.
On 11/27/13 12:48 AM, Volker Simonis wrote:
Hi Sergey,
on AIX, there's already a typedef for "boolean_t" in sys/types.h
that's why we have to omit it from ecc_impl.h to avoid compile errors.
The question regarding the copyright header
Looking only at what you needed to change this time round, all seems
fine now.
-phil.
On 11/26/13 8:23 AM, Volker Simonis wrote:
Hi,
thanks to everybody for the prompt and helpful reviews. Here comes the
final webrev which incorporates all the corrections and suggestions
from the second rev
Hi.
>> http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/
> + src/solaris/classes/java/lang/UNIXProcess.java.aix
> 2 * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights
> reserved.
> 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
Oracle copyrig
On 26/11/2013 16:23, Volker Simonis wrote:
Hi,
thanks to everybody for the prompt and helpful reviews. Here comes the
final webrev which incorporates all the corrections and suggestions from
the second review round:
http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/
I've successfully buil
Hi,
thanks to everybody for the prompt and helpful reviews. Here comes the
final webrev which incorporates all the corrections and suggestions from
the second review round:
http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/
I've successfully build (and run some smoke tests) with these chang
Hi, Petr.
The fix looks good.
On 26.11.2013 19:23, Petr Pchelko wrote:
Please review the updated fix:
http://cr.openjdk.java.net/~pchelko/8011142/webrev.01/
It appears that we do not have a regression test for the AppContext fix.
So it was decided to change the test instead of removing it.
Tha
The fix looks good to me.
--
best regards,
Anthony
On 11/26/2013 07:23 PM, Petr Pchelko wrote:
Please review the updated fix:
http://cr.openjdk.java.net/~pchelko/8011142/webrev.01/
It appears that we do not have a regression test for the AppContext fix.
So it was decided to change the test ins
Please review the updated fix:
http://cr.openjdk.java.net/~pchelko/8011142/webrev.01/
It appears that we do not have a regression test for the AppContext fix.
So it was decided to change the test instead of removing it.
Thank you.
With best regards. Petr.
On 26.11.2013, at 17:19, Anthony Petrov
Changeset: 7d33bca26091
Author:pchelko
Date: 2013-11-26 18:50 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7d33bca26091
8024161: [TEST_BUG] [macosx] java/awt/Menu/OpensWithNoGrab/OpensWithNoGrab.java
failed "menu was opened by first click after opened Choice"
Reviewed-by:
Hi. Petr.
The fix looks good. Please update date in test header before the push.
On 26.11.2013 15:10, Petr Pchelko wrote:
Hello, AWT Team.
Please review the fix for a test bug:
https://bugs.openjdk.java.net/browse/JDK-8024161
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8024161/
Changeset: ab933b508274
Author:mcherkas
Date: 2013-11-26 17:16 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ab933b508274
8028271: Wrong alt processing during switching between windows.
Reviewed-by: serb, alexsch
!
test/javax/swing/plaf/windows/WindowsRootPaneUI/WrongAltP
+1.
--
best regards,
Anthony
On 11/26/2013 04:16 PM, Petr Pchelko wrote:
Hello, AWT Team.
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8011142
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8011142/webrev/
The MainAppContext test verified that th
Looks fine.
--
best regards,
Anthony
On 11/26/2013 03:10 PM, Petr Pchelko wrote:
Hello, AWT Team.
Please review the fix for a test bug:
https://bugs.openjdk.java.net/browse/JDK-8024161
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8024161/webrev/
The test is intended only for X
Changeset: 610da7dcd1be
Author:bagiras
Date: 2013-11-26 15:57 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/610da7dcd1be
7160604: Using non-opaque windows - popups are initially not painted correctly
Reviewed-by: serb, alexsch
! src/share/classes/javax/swing/JPopupMenu.jav
Hello, AWT Team.
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8011142
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8011142/webrev/
The MainAppContext test verified that the mainAppContext is created when
there's already another AppContext created.
Hello, AWT Team.
Please review the fix for a test bug:
https://bugs.openjdk.java.net/browse/JDK-8024161
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8024161/webrev/
The test is intended only for XToolkit, but was not aware of the mac platform.
With best regards. Petr.
Hi Phil,
thanks a lot for the review. Please find my comments inline:
On Tue, Nov 26, 2013 at 12:24 AM, Phil Race wrote:
> Hi,
> I see you've already received a ton of good feedback on this v2.
>
> I have just a few things to add.
> I don't know what symlinks might exist on AIX but it seems o
Changeset: 6829d28b3da5
Author:malenkov
Date: 2013-11-26 13:30 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6829d28b3da5
8028054: com.sun.beans.finder.MethodFinder has unsynchronized access to a
static Map
Reviewed-by: alexsch, serb
! src/share/classes/com/sun/beans/find
Hi Volker,
The security changes look fine. I'm not crazy that we now have to
maintain one additional java.security file which is the exact same as
java.security-linux, but this is really an existing issue with
duplicated content across the java.security files which I will try to
fix early in
20 matches
Mail list logo
