In the native code, is ImageReprese-M-tations really a class with a
spelling error, or is that a typo in the new code?
In any case, all of this code was outside my areas of familiarity so I
could only give it a passing "nothing smells wrong here" check, other
than that spelling anomaly...
Hi Alexander,
It looks good to go. I only skimmed the other parts of the fix on the
assumption that they haven't changed in a few revisions, but it all
looked good. Glad to see you fixed the dimension issues in the observer
as well.
I'll follow up with a list of future issues to track...
Thanks for the update, Alexander. I understand.
So, my only concerns that remain are:
1. The membership of the resizeImageRepresentations() method.
2. The encapsulation of the logic handling the
Image/MultiResolutionImage case (see at the bottom of my original message).
--
best regards,
Anth
On 12/3/2013 9:06 PM, Anthony Petrov wrote:
Hi Alexander,
If we go with this fix, I suggest to move the
CImage.Creator.resizeImageRepresentations() to the CImage class and
make it a member method, so that you don't need to pass a CImage
reference to it as an argument.
I will update this.
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8011059/webrev.14
- Observer and rvObserver are used to get width/hight from
image/rvImage in SunGraphics2D
- width and height are rounded up in the image observer wrapper
- width and height are also rescaled for
Looks good.
--
best regards,
Anthony
On 12/03/2013 06:44 PM, andrei.eremeev wrote:
Hi, AWT team.
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-7112454
The fix is available at:
http://cr.openjdk.java.net/~yan/7112454/webrev.diff.00/
Test moved to open:
http://c
Changeset: 613fdc6afb2c
Author:serb
Date: 2013-12-04 15:55 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/613fdc6afb2c
8029382: [macosx] Need test for JDK-7161437
Reviewed-by: pchelko, anthony
+
test/java/awt/FileDialog/FileDialogForDirectories/FileDialogForDirectories.htm
Changeset: 1490b2b2af97
Author:pchelko
Date: 2013-12-04 15:41 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1490b2b2af97
8028484: [TEST_BUG][macosx]
closed/java/awt/MouseInfo/JContainerMousePositionTest fails
Reviewed-by: anthony, serb
+ test/java/awt/MouseInfo/JContainer
Hi, Petr.
The fix looks good.
On 03.12.2013 16:05, Petr Pchelko wrote:
Hello, Sergey.
Thank you for the review, the new version is available here:
Test diff: http://cr.openjdk.java.net/~pchelko/8028484/webrev_diff/
Open diff: http://cr.openjdk.java.net/~pchelko/8028484/webrev_new.v1/
With best
Hello, Sergey.
The fix looks good to me.
With best regards. Petr.
On 02.12.2013, at 20:41, Anthony Petrov wrote:
> Hi Sergey,
>
> The fix looks fine to me.
>
> --
> best regards,
> Anthony
>
> On 12/02/2013 08:37 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk 8.
>> Th
Changeset: 233cc95e1a0a
Author:alitvinov
Date: 2013-12-04 12:29 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/233cc95e1a0a
8025775: JNI warnings in TryXShmAttach
Reviewed-by: art, anthony
! src/solaris/classes/sun/awt/X11/XConstants.java
! src/solaris/classes/sun/awt/X11/X
11 matches
Mail list logo
