Re: [OpenJDK 2D-Dev] JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

2014-05-19 Thread Alan Bateman
On 19/05/2014 07:53, Paul Sandoz wrote: If i don't have permission to push to the client repo (which might be likely) i will need to hand over the patch to yourself or Sergey to commit. And i presume this will have to be a separate issue. If you do decide to split this then it will require crea

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-05-19 Thread Alexander Scherbatiy
Hi Phil, On 5/16/2014 9:12 PM, Phil Race wrote: I think Jim was looking at this. I am not sure if you yet answered all his questions/concerns. There's a lot of API here and it will take more time than I have right now just to get my head around it so do not expect a quick answer. 1. Why

Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-05-19 Thread Dmitriy Ermashov
Hi, Please review the changeset for bug: https://bugs.openjdk.java.net/browse/JDK-8043131 The webrev is here: http://cr.openjdk.java.net/~yan/8043131/webrev.00/ This is one more batch of functional AWT (ShapedAndTranslucentWindows and GC) tests are ought to be moved to regression tree. -- Th

[9] Review request for 8036110 In TextField can only select text visible or to the left of the cursor

2014-05-19 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8036110 webrev: http://cr.openjdk.java.net/~alexsch/8036110/webrev.00 This is a regression from the fix 7092551 where the EDIT control has been changed to the RICHEDIT. GetScrollInfo(hWnd, SB_HORZ, &scrollin

Re: [9] Review request for 8036110 In TextField can only select text visible or to the left of the cursor

2014-05-19 Thread Sergey Bylokhov
Hello, Alexander. Can you check that the test works correctly on linux/osx. On 19.05.2014 19:05, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8036110 webrev: http://cr.openjdk.java.net/~alexsch/8036110/webrev.00 This is a reg

Re: [OpenJDK 2D-Dev] JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

2014-05-19 Thread Phil Race
On 5/19/2014 12:50 AM, Alan Bateman wrote: On 19/05/2014 07:53, Paul Sandoz wrote: If i don't have permission to push to the client repo (which might be likely) i will need to hand over the patch to yourself or Sergey to commit. And i presume this will have to be a separate issue. If you do dec

Re: RFR: Allow using the system libjpeg

2014-05-19 Thread Anthony Petrov
Hi Omair, common/autoconf/libraries.m4 624 [use libjpeg from build system or OpenJDK source (system, bundled) @<:bundled@:>@])]) "@<:bundled@:>@" should read "@<:@bundled@:>@" - note the missing @. make/lib/Awt2dLibraries.gmk 1236 LIBJPEG_CFLAGS := $(JDK_TOPDIR)/src/share/native

CFV: New jdk9 Committer: David DeHaven

2014-05-19 Thread Anthony Petrov
I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 Committer David has contributed a number of patches to JDK 7u, 8, 8u, and 9. Also, he has reviewed many fixes that went into those releases. The AWT Group particularly values his deep expertise in Mac OS X, which helped us

Re: CFV: New jdk9 Committer: David DeHaven

2014-05-19 Thread Petr Pchelko
Vote: YES. With best regards. Petr. On May 19, 2014, at 11:51 PM, Anthony Petrov wrote: > I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 > Committer > > David has contributed a number of patches to JDK 7u, 8, 8u, and 9. Also, he > has reviewed many fixes that went int

Re: CFV: New jdk9 Committer: David DeHaven

2014-05-19 Thread Mario Torre
Vote: yes Cheers, Mario Il 19/mag/2014 21:53 "Anthony Petrov" ha scritto: > I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 > Committer > > David has contributed a number of patches to JDK 7u, 8, 8u, and 9. Also, > he has reviewed many fixes that went into those releases.

Re: CFV: New jdk9 Committer: David DeHaven

2014-05-19 Thread Henry Jen
Vote: Yes Cheers, Henry On 05/19/2014 12:51 PM, Anthony Petrov wrote: I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 Committer David has contributed a number of patches to JDK 7u, 8, 8u, and 9. Also, he has reviewed many fixes that went into those releases. The AWT Grou

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

2014-05-19 Thread Pete Brunet
On 5/16/14 11:04 AM, Pete Brunet wrote: > On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: >> On 5/16/2014 7:15 PM, Pete Brunet wrote: >>> On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: Hi Peter, Is there any difference between AccessibleAWTFocusHandler and AccessibleFoc

Re: CFV: New jdk9 Committer: David DeHaven

2014-05-19 Thread Naoto Sato
Vote: yes Naoto On 5/19/26 H, 12:51 PM, Anthony Petrov wrote: I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 Committer David has contributed a number of patches to JDK 7u, 8, 8u, and 9. Also, he has reviewed many fixes that went into those releases. The AWT Group partic

Re: CFV: New jdk9 Committer: David DeHaven

2014-05-19 Thread Brent Christian
Vote: yes -Brent On 5/19/14 12:51 PM, Anthony Petrov wrote: I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 Committer David has contributed a number of patches to JDK 7u, 8, 8u, and 9. Also, he has reviewed many fixes that went into those releases. The AWT Group particul

Re: CFV: New jdk9 Committer: David DeHaven

2014-05-19 Thread Volker Simonis
Vote: yes On Mon, May 19, 2014 at 9:51 PM, Anthony Petrov wrote: > I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 > Committer > > David has contributed a number of patches to JDK 7u, 8, 8u, and 9. Also, he > has reviewed many fixes that went into those releases. The AWT G

Re: CFV: New jdk9 Committer: David DeHaven

2014-05-19 Thread Wang Weijun
Vote: yes -weijun On May 20, 2014, at 3:51, Anthony Petrov wrote: > I hereby nominate David DeHaven (OpenJDK user name: ddehaven) for jdk9 > Committer

Re: [OpenJDK 2D-Dev] JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

2014-05-19 Thread Paul Sandoz
On May 19, 2014, at 6:18 PM, Phil Race wrote: > On 5/19/2014 12:50 AM, Alan Bateman wrote: >> On 19/05/2014 07:53, Paul Sandoz wrote: >>> If i don't have permission to push to the client repo (which might be >>> likely) i will need to hand over the patch to yourself or Sergey to commit. >>> An