Re: AWT Dev Review Request for 8041915: Move 8 awt tests to OpenJDK regression tests tree

2014-05-26 Thread Dmitriy Ermashov
Hi, I still have no second successful review.. Could you please look at the fix of https://bugs.openjdk.java.net/browse/JDK-8041915 Webrev is here: http://cr.openjdk.java.net/~yan/8041915/webrev.01/ It is a part of test colocation. Thanks, Dima On 05/12/2014 03:16 PM, Dmitriy Ermashov wrote:

Re: AWT Dev Review Request for 8041915: Move 8 awt tests to OpenJDK regression tests tree

2014-05-26 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 5/26/2014 1:41 PM, Dmitriy Ermashov wrote: Hi, I still have no second successful review.. Could you please look at the fix of https://bugs.openjdk.java.net/browse/JDK-8041915 Webrev is here:

Re: AWT Dev Review Request for 8041915: Move 8 awt tests to OpenJDK regression tests tree

2014-05-26 Thread Dmitriy Ermashov
Thanks for review! -dima On 05/26/2014 02:21 PM, Alexander Scherbatiy wrote: The fix looks good for me. Thanks, Alexandr. On 5/26/2014 1:41 PM, Dmitriy Ermashov wrote: Hi, I still have no second successful review.. Could you please look at the fix of

Re: AWT Dev Review Request for 8041915: Move 8 awt tests to OpenJDK regression tests tree

2014-05-26 Thread Sergey Bylokhov
Hi, Dmitriy. One of the test has incorrect copyright: 23 /* 24 * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. 25 * ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms. 26 */ I was thinking that the author of these tests is Alexander Kouznetsov,

Re: AWT Dev [9] Review request for 8042465: Applet menus not rendering when browser is full screen on Mac

2014-05-26 Thread dmitry markov
Hello, Could you review the updated fix, please? The new version of the webrev is located at - http://cr.openjdk.java.net/~dmarkov/8042465/jdk9/webrev.01/ the list of changes: 1. Removed the NSWindowCollectionBehaviorCanJoinAllSpaces option from definition of collection behavior, since it

Re: AWT Dev [9] Review request for 8042465: Applet menus not rendering when browser is full screen on Mac

2014-05-26 Thread Anthony Petrov
Hi Dmitry, The fix seems to cover only the case when an app is running with the default LF. What is the solution for custom LFs? Can we move the logic for cache disabling to the shared popup-related code somewhere so that the issue is fixed for all LFs at once? -- best regards, Anthony On

Re: AWT Dev Review Request for 8041915: Move 8 awt tests to OpenJDK regression tests tree

2014-05-26 Thread Dmitriy Ermashov
On 05/26/2014 04:04 PM, Sergey Bylokhov wrote: Hi, Dmitriy. One of the test has incorrect copyright: 23 /* 24 * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. 25 * ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms. 26 */ Changes are already

AWT Dev Review Request for 8043972: Remove wrong copyright notice in jdk/test/java/awt/Frame/DecoratedExceptions/DecoratedExceptions.java

2014-05-26 Thread Dmitriy Ermashov
Hi, Please review the changeset for: https://bugs.openjdk.java.net/browse/JDK-8043972 The webrev is here: http://cr.openjdk.java.net/~dermashov/8043972/webrev.00/ In addition to https://bugs.openjdk.java.net/browse/JDK-8041915 There was a wrong copyright in test header. -- Thanks, Dima