Re: Review Request for 8047180: Move functional tests AWT_Headless/Automated to OpenJDK repository

2014-06-19 Thread Petr Pchelko
>> Did you check that these tests pass on all platforms? > Sure. I've verified tests on Windows 7, Ubuntu 14.04, OS X 10.9, Solaris 11 > and Ubuntu 10.04 (arm CPU). > Pass rate is 100% everywhere. Nice to hear that. The fix looks good to me. With best regards. Petr. On 20 июня 2014 г., at 10:26

Re: Review Request for 8047180: Move functional tests AWT_Headless/Automated to OpenJDK repository

2014-06-19 Thread Dmitriy Ermashov
On 06/19/2014 06:39 PM, Petr Pchelko wrote: Hello, Dmitriy. It's impossible to review)) Impossible is nothing! (c)) I've briefly skimmed the classes and didn't see any problems with the tests. Looks like these are pretty much the same) These tests verify that GUI (AWT & Swing) components do n

Re: Fwd: RFR: make life easier for general java plugin

2014-06-19 Thread Mario Torre
On Thu, 2014-06-19 at 17:26 +0200, Jiri Vanek wrote: > For now, I'm going to derive the API from original plugin-applet-hole > patch little bit reduced by > experience from [3] I don't have myself a lot of experience with the Plugin API (from an implementation POV), but I would guess that the re

Re: Fwd: RFR: make life easier for general java plugin

2014-06-19 Thread Jiri Vanek
On 06/19/2014 04:46 PM, Petr Pchelko wrote: Hello, Jiri. Sorry for the delayed answer. np :) Thank you for Answer! From the code point of view you current change looks OK to me. It's an internal package and we can change the access modifier easily. The more general question is what are yo

Re: Fwd: RFR: make life easier for general java plugin

2014-06-19 Thread Petr Pchelko
Hello, Jiri. Sorry for the delayed answer. From the code point of view you current change looks OK to me. It's an internal package and we can change the access modifier easily. The more general question is what are you going to achieve by making this change? In JDK-9 we would have modules and y

Re: Review Request for 8047180: Move functional tests AWT_Headless/Automated to OpenJDK repository

2014-06-19 Thread Petr Pchelko
Hello, Dmitriy. It's impossible to review)) I've briefly skimmed the classes and didn't see any problems with the tests. Looks like these are pretty much the same) Did you check that these tests pass on all platforms? Thank you. With best regards. Petr. On 19 июня 2014 г., at 18:21, Dmitriy E

Re: Fwd: RFR: make life easier for general java plugin

2014-06-19 Thread Jiri Vanek
On 06/16/2014 11:34 AM, Jiri Vanek wrote: ping?? ping? On 05/21/2014 05:02 PM, Jiri Vanek wrote: Hi! IcedTea-Web [1] have now patch [3] from [2] thread, to work pretty smooth with all Icedteas, all Openjdks and all Oracle javas. It even do work with IBM java. However, we needed to include

Review Request for 8047180: Move functional tests AWT_Headless/Automated to OpenJDK repository

2014-06-19 Thread Dmitriy Ermashov
Hi AWT team, Swing team, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8047180 Webrev is here: http://cr.openjdk.java.net/~dermashov/8047180/webrev.00/ It is one more batch of functional tests moving to OpenJDK repo. This batch covers just one functional test AWT_Headless/

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

2014-06-19 Thread Petr Pchelko
Hello, Alan. Thank you for the review. > Do we know if anyone has been editing the file in ${java.home}/lib? I couldn't find any examples on the internet although I've done a very extensive search, so I we could add a property later if someone would request it. With best regards. Petr. On 19

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

2014-06-19 Thread Alan Bateman
On 19/06/2014 12:17, Petr Pchelko wrote: Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/ This is another step in datatransfer modularization work. This part of the work

[9] Review Request: 8047336 Read flavormap.properties as resource

2014-06-19 Thread Petr Pchelko
Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/ This is another step in datatransfer modularization work. This part of the work needs a CCC, so I've moved it out to a s