Re: Review request for 8040076: java.awt.List objects allowing multiple selections are not GC-ed

Hello, Artem. >> As Anthony said it's just for limiting visibility. I didn’t understand this actually. The new version looks good to me. With best regards. Petr. > On Jul 1, 2014, at 10:40 PM, Anthony Petrov wrote: > > Hi Artem, > > Note that assert() [1] is still not a run-time check bec

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hi Petr, The fix looks fine to me. Only one question: src/share/classes/java/awt/datatransfer/SystemFlavorMap.java 234 } catch (IOException e) { 235 System.err.println("Warning reading flavor mapping: " + e.getMessage()); Is there a reason to hide the stack trace of the

Re: Review request for 8040076: java.awt.List objects allowing multiple selections are not GC-ed

Hi Artem, Note that assert() [1] is still not a run-time check because we specify -DNDEBUG when building Release binaries. To make it a runtime check, the code should check the condition explicitly, and if it's false, then raise a Java exception (e.g. AWTError) and return from the JNI method.

[9] Review request for 8046495: KeyEvent can not be accepted in quick mouse clicking

Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8046495/9/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8046495 *Problem:*

Re: Review request for 8040076: java.awt.List objects allowing multiple selections are not GC-ed

Hi, Antony and Petr! Thank you for detailed review. I Hope this version is better. Link: http://cr.openjdk.java.net/~mcherkas/artem/webrev.05/ Petr: "4. Lines 37-43. Normally we do not use blocks to group the code together." As Anthony said it's just for limiting visibility. But maybe code lo

Re: [9] Review Request: 8048265 AWT crashes inside CCombinedSegTable::In called from Java_sun_awt_windows_WDefaultFontCharset_canConvert

Looks fine. -- best regards, Anthony On 7/1/2014 9:12 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. Bug was triggered by the change in JDK-8032435, when WingDings.java was changed to non-public class. This class is used in native, and looks like some of these places, when e

Re: [9] Review Request: 8048265 AWT crashes inside CCombinedSegTable::In called from Java_sun_awt_windows_WDefaultFontCharset_canConvert

Hi Sergey, the fix looks good to me. -- Thanks, Alexander. 01.07.2014 9:12, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. Bug was triggered by the change in JDK-8032435, when WingDings.java was changed to non-public class. This class is used in native, and looks like some of

Review Request for 8048246: Move AWT_DnD/Clipboard/Automated functional tests to OpenJDK

Hi, Please review a new batch of functional AWT tests. Clipboard tests this time. http://cr.openjdk.java.net/~dermashov/8048246/webrev.00/ Corresponding bug: https://bugs.openjdk.java.net/browse/JDK-8048246 The changeset is pretty large, but, as always, it is several times smaller than origi

Re: [9] Review Request: 8047336 Read flavormap.properties as resource

Hello, The changes in the public API have been approved, so let me continue the review process. For your convenience: The bug: https://bugs.openjdk.java.net/browse/JDK-8047336 The fix: http://cr.openjdk.java.net/~pchelko/9/8047336/webrev.00/ Until now we've been discussing an abstract question