Hello Petr,
> I'm not quite sure I completely understand why do we need these
special helper components.
At the moment we have a lot of functional tests (not only event-related)
testing the lightweight components (LWButton, LWList) and having the
same test logic as the corresponding tests fo
Petr,
Thanks for review!
With regards,
Dmitriy Ermashov
> 03 июля 2014 г., в 18:55, Petr Pchelko написал(а):
>
> Looks good to me.
>
> With best regards. Petr.
>
>> On Jul 3, 2014, at 6:49 PM, Dmitriy Ermashov
>> wrote:
>>
>> Hi,
>> I've updated the webrev, so could you please review it?
Hello, Alexander.
Sorry for the delay.
First of all, could you please describe the approach used in these tests. I'm
not quite sure
I completely understand why do we need these special helper components.
Some comments:
1. LWList: 32 typo LeightWeight
2. MultipleMouseButtonsTest: 219 - you cou
Hello Petr,
Thank you for your review.
Regards,
Alexey.
On 04.07.2014 15:14, Petr Pchelko wrote:
Hello, Alexey.
Your test does not test the JFileChooser hang, because the bug is reproducible
only in plugin mode where TK thread doesn't
have an AppContext and we update the ThemeReader on the
Thanks for the update. The fix looks good to me.
--
best regards,
Anthony
On 7/4/2014 5:49 PM, Alexey Ivanov wrote:
Hi Anthony,
Thank you for your review.
You're right, there's a potential NPE at line 941 in WToolkit.java.
I've added null check to avoid NPE.
Could you please review the upda
Hi Anthony,
Thank you for your review.
You're right, there's a potential NPE at line 941 in WToolkit.java.
I've added null check to avoid NPE.
Could you please review the updated webrev?
http://cr.openjdk.java.net/~aivanov/8046559/jdk9/webrev.01/
Thank you,
Alexey.
On 04.07.2014 14:12, Anth
Sorry, just a reminder.
Regards,
Alexander
On 09.06.2014 14:57, alexander stepanov wrote:
Sorry, just a reminder.
Thanks,
Alexander
On 28.05.2014 15:42, alexander stepanov wrote:
Hello,
Could you please review the fix for the following bug:
https://bugs.openjdk.java.net/browse/JDK-8043126
Hello, Alexey.
> Your test does not test the JFileChooser hang, because the bug is
> reproducible only in plugin mode where TK thread doesn't
> have an AppContext and we update the ThemeReader on the Toolkit thread. Your
> test runs in standalone mode
> where completely different codepath is us
On 7/3/2014 2:25 PM, Alexander Scherbatiy wrote:
On 7/3/2014 1:15 PM, dmitry markov wrote:
Hi Alexandr,
Thank you for review.
For the use case you described - when we move back to the first
browser window with 3 applets, the first applet (not the second one)
will receive the focus. This behav
Hello, Alexey.
Your test does not test the JFileChooser hang, because the bug is reproducible
only in plugin mode where TK thread doesn't
have an AppContext and we update the ThemeReader on the Toolkit thread. Your
test runs in standalone mode
where completely different codepath is used. So I s
Hi Alexey,
src/windows/classes/sun/awt/windows/WToolkit.java
940 final Map props = getWProps();
941 updateXPStyleEnabled(props.get(XPSTYLE_THEME_ACTIVE));
971 private synchronized Map getWProps() {
972 return (wprops != null) ? wprops.getProperties() : null;
11 matches
Mail list logo
