Re: [7u-dev] Review request for JDK-8046559: NPE when changing Windows theme

Hello, Alexey. Looks OK to me too. With best regards. Petr. > On Jul 11, 2014, at 1:43 AM, Anthony Petrov wrote: > > Hi Alexey, > > I skimmed through the changes and they look fine to me. +1. > > -- > best regards, > Anthony > > On 7/10/2014 7:59 PM, Alexey Ivanov wrote: >> Hi AWT, Swing te

Re: [9] Review Request: 8032864 [macosx] sigsegv (0Xb) Being Generated When Starting JDev With Voiceover Running

Hi Petr, I'm fine with the targeted fix. We often do a similar thing in JavaFX when processing various events, so the approach is proven to work good. However, generally I agree with your comment from the bug report about the necessity to process dispose selectors in the outer event loop only

Re: [7u-dev] Review request for JDK-8046559: NPE when changing Windows theme

Hi Alexey, I skimmed through the changes and they look fine to me. +1. -- best regards, Anthony On 7/10/2014 7:59 PM, Alexey Ivanov wrote: Hi AWT, Swing teams, Could you please review the backport of JDK-8046559 to jdk7: bug: https://bugs.openjdk.java.net/browse/JDK-8046559 webrev:

Re: [9] Review Request: 8049583 Test closed/java/awt/List/ListMultipleSelectTest/ListMultipleSelectTest fails on Window XP

Hi Sergey, I agree if this change goes to 8u as the least risky thing we can do now. For 9 I'd prefer to fix the root cause of the problem, which is related to the wrong cast of e.g. AwtList::_IsSelected from (jboolean (*)(void*)) to (void *(*)(void *)) - we simply should have never performed

[7u-dev] Review request for JDK-8046559: NPE when changing Windows theme

Hi AWT, Swing teams, Could you please review the backport of JDK-8046559 to jdk7: bug: https://bugs.openjdk.java.net/browse/JDK-8046559 webrev: http://cr.openjdk.java.net/~aivanov/8046559/jdk7/webrev.00/ Changes between jdk9 and jdk7: I replaced labmda expression in WToolkit.java with

Re: [9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

Hi, Alexander. The fix looks good. On 10.07.2014 17:11, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8049198/webrev.01 ThreadUtilities is used instead of JNFRunLoop. Thanks, Alexandr. On 7/10/2014 4:49 PM, Petr Pchelko

Re: [9] Review Request: 8049583 Test closed/java/awt/List/ListMultipleSelectTest/ListMultipleSelectTest fails on Window XP

Hello, Sergey. The fix looks good to me. I assume that you will file a separate bug for returning parfait problems. With best regards. Petr. On 10 июля 2014 г., at 18:11, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk 9. > The bug reproduced on xp only, regression of JDK-8

[9] Review Request: 8049583 Test closed/java/awt/List/ListMultipleSelectTest/ListMultipleSelectTest fails on Window XP

Hello. Please review the fix for jdk 9. The bug reproduced on xp only, regression of JDK-8035739 Description: void * is 4 bytes jboolean is 1 byte. Before the fix we cast to jboolean after the fix not[1]. On XP part of the return value is not

Re: [9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

Hello, Alexander. The fix looks good. With best regards. Petr. On 10 июля 2014 г., at 17:11, Alexander Scherbatiy wrote: > > Could you review the updated fix: >http://cr.openjdk.java.net/~alexsch/8049198/webrev.01 > > ThreadUtilities is used instead of JNFRunLoop. > >Thanks,

Re: [9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8049198/webrev.01 ThreadUtilities is used instead of JNFRunLoop. Thanks, Alexandr. On 7/10/2014 4:49 PM, Petr Pchelko wrote: Hello, Alexander. Please use ThreadUtilities instead of the JNFRunLoop. With

[9] Review Request: 8032864 [macosx] sigsegv (0Xb) Being Generated When Starting JDev With Voiceover Running

Hello, AWT team. Please review a small fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8032864 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8032864/webrev.01/ I failed to create a general fix for the core problem, so I've made a point fix for this bug. The problem i

Re: [9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

Hello, Alexander. Please use ThreadUtilities instead of the JNFRunLoop. With best regards. Petr. On 10 июля 2014 г., at 16:42, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8049198 > webrev: http://cr.openjdk.java.net

[9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8049198 webrev: http://cr.openjdk.java.net/~alexsch/8049198/webrev.00 NSScreen call is moved to perform on the main thread. Thanks, Alexandr.

Re: [9] Review Request: 8049830 Remove reflection from ScreenMenuBar

Hi, Petr. The fix looks good. On 10.07.2014 12:50, Anthony Petrov wrote: +1 -- best regards, Anthony On 7/10/2014 11:26 AM, Petr Pchelko wrote: Hello, AWT Team. Please review a simple cleanup: https://bugs.openjdk.java.net/browse/JDK-8049830 The fix is available here: http://cr.openjdk.java.

Re: [9] Review Request: 8049830 Remove reflection from ScreenMenuBar

+1 -- best regards, Anthony On 7/10/2014 11:26 AM, Petr Pchelko wrote: Hello, AWT Team. Please review a simple cleanup: https://bugs.openjdk.java.net/browse/JDK-8049830 The fix is available here: http://cr.openjdk.java.net/~pchelko/9/8049830/webrev.00/ Just replacing nasty reflection with pro

[9] Review Request: 8049830 Remove reflection from ScreenMenuBar

Hello, AWT Team. Please review a simple cleanup: https://bugs.openjdk.java.net/browse/JDK-8049830 The fix is available here: http://cr.openjdk.java.net/~pchelko/9/8049830/webrev.00/ Just replacing nasty reflection with proper Accessor pattern. With best regards. Petr.