Re: RFR [9] Modular Source Code

2014-08-27 Thread Anthony Petrov
Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AWT (e.g. the font-, color-, d3d-, and opengl-related files) even though they're compiled into the awt native libraries. -- b

Re: Review Request for 8039749: Migrate needed functionality from all subclasses of java.awt.Robot in jdk/test directory to the ancestor

2014-08-27 Thread Anthony Petrov
Hi Dmitriy, While I realize that all the new methods are useful when writing JDK regression tests, do you have any evidence that would suggest that these same methods could be useful to and/or have been requested by external developers? All of them look like convenient APIs and I'm not entirel

Re: RFR [9] Modular Source Code

2014-08-27 Thread Alan Bateman
On 27/08/2014 11:57, Anthony Petrov wrote: Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AWT (e.g. the font-, color-, d3d-, and opengl-related files) even though they're co

Re: Review Request for 8039749: Migrate needed functionality from all subclasses of java.awt.Robot in jdk/test directory to the ancestor

2014-08-27 Thread Dmitriy Ermashov
Hi Anthony, Thanks for your review. At first, let me focus on fact that the actual motivation of moving functionality to java.awt.Robot is the Jigsaw project. We (SQE) will be unable to use internal java API after the project will be finished (ExtendedRobot just will not compile, for example)

Re: Review Request for 8039749: Migrate needed functionality from all subclasses of java.awt.Robot in jdk/test directory to the ancestor

2014-08-27 Thread Yuri Nesterenko
On 08/27/2014 04:25 PM, Dmitriy Ermashov wrote: Hi Anthony, Thanks for your review. At first, let me focus on fact that the actual motivation of moving functionality to java.awt.Robot is the Jigsaw project. We (SQE) will be unable to use internal java API after the project will be finished (Ext

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

2014-08-27 Thread Alexander Zvegintsev
Hello Alex, You are welcome and I am glad to see your contribution to OpenJDK project. Your fix looks good to me, it resolves JDK-6624085 issue too, so let it be fixed under this bug ID. As I can see in jdk9-dev mailing list OCA has been signed by you, so no further action is required from you