Re: RFR [9] Modular Source Code

2014-08-28 Thread Alan Bateman
On 28/08/2014 20:36, Phil Race wrote: * All of the awt-related directories (libawt_* and common) include an unnecessary extra layer, the "sun" directory. It is not needed anymore, Let's *not* do that. It also affects the destination package. Remember sun.* is the protected top-level package ..

Re: [OpenJDK 2D-Dev] RFR [9] Modular Source Code

2014-08-28 Thread Phil Race
On 8/28/2014 12:36 PM, Phil Race wrote: * All of the awt-related directories (libawt_* and common) include an unnecessary extra layer, the "sun" directory. It is not needed anymore, Let's *not* do that. It also affects the destination package. Remember sun.* is the protected top-level package .

Re: RFR [9] Modular Source Code

2014-08-28 Thread Phil Race
* All of the awt-related directories (libawt_* and common) include an unnecessary extra layer, the "sun" directory. It is not needed anymore, Let's *not* do that. It also affects the destination package. Remember sun.* is the protected top-level package .. and people won't always be running in j

Re: RFR [9] Modular Source Code

2014-08-28 Thread Anthony Petrov
Thanks! -- best regards, Anthony On 8/28/2014 1:00 PM, Magnus Ihse Bursie wrote: On 2014-08-27 12:57, Anthony Petrov wrote: Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AW

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

2014-08-28 Thread Anthony Petrov
The fix looks great to me. +1. -- best regards, Anthony On 8/27/2014 8:31 PM, Alexander Zvegintsev wrote: Hello Alex, You are welcome and I am glad to see your contribution to OpenJDK project. Your fix looks good to me, it resolves JDK-6624085 issue too, so let it be fixed under this bug ID.

Re: Review Request for 8039749: Migrate needed functionality from all subclasses of java.awt.Robot in jdk/test directory to the ancestor

2014-08-28 Thread Anthony Petrov
Hi Dmitriy, On 8/28/2014 1:14 PM, Dmitriy Ermashov wrote: On 08/28/2014 12:09 PM, Anthony Petrov wrote: On 8/27/2014 4:54 PM, Yuri Nesterenko wrote: On 08/27/2014 04:25 PM, Dmitriy Ermashov wrote: At first, let me focus on fact that the actual motivation of moving functionality to java.awt.Ro

Re: [9] Review request for 8055664: move 14 tests about setLocationRelativeTo to jdk

2014-08-28 Thread Alexander Zvegintsev
Still looks good to me. -- Thanks, Alexander. On 08/28/2014 06:38 PM, Yuri Nesterenko wrote: Thank you Alexander! new version: http://cr.openjdk.java.net/~yan/8055664/webrev.01 -yan On 08/28/2014 05:59 PM, Alexander Zvegintsev wrote: Hello Yuri, IIUC, this test may fail on Ubuntu due to

Re: [9] Review request for 8055664: move 14 tests about setLocationRelativeTo to jdk

2014-08-28 Thread Yuri Nesterenko
Thank you Alexander! new version: http://cr.openjdk.java.net/~yan/8055664/webrev.01 -yan On 08/28/2014 05:59 PM, Alexander Zvegintsev wrote: Hello Yuri, IIUC, this test may fail on Ubuntu due to JDK-8036915 [1]. Oh yes, I even put it to @bug tag. the fix looks good to me in general, but

Re: [9] Review request for 8055664: move 14 tests about setLocationRelativeTo to jdk

2014-08-28 Thread Alexander Zvegintsev
Hello Yuri, IIUC, this test may fail on Ubuntu due to JDK-8036915 [1]. the fix looks good to me in general, but I have some minor comments: 91 testEverything = false; // NB: change this to true to test everything I think this line can be removed and comment should be at line 41. As fo

Re: [7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Alexander Potochkin
The fix looks fine Thanks alexp On 8/28/2014 11:29 AM, Alexey Ivanov wrote: Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.openjdk.java.net/~aivanov/8056156/jdk7/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JD

Re: Review Request for 8039749: Migrate needed functionality from all subclasses of java.awt.Robot in jdk/test directory to the ancestor

2014-08-28 Thread Dmitriy Ermashov
Hi Anthony, On 08/28/2014 12:09 PM, Anthony Petrov wrote: Hi Dmitriy, Yuri, On 8/27/2014 4:54 PM, Yuri Nesterenko wrote: On 08/27/2014 04:25 PM, Dmitriy Ermashov wrote: At first, let me focus on fact that the actual motivation of moving functionality to java.awt.Robot is the Jigsaw project. W

Re: RFR [9] Modular Source Code

2014-08-28 Thread Magnus Ihse Bursie
On 2014-08-27 12:57, Anthony Petrov wrote: Hi Magnus, Those look like reasonable suggestions. Could you please file separate bugs for each of these issues? Also, please note that most of them belong to 2D, not AWT (e.g. the font-, color-, d3d-, and opengl-related files) even though they're co

Re: [7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Seán Coffey
Approved. regards, Sean. On 28/08/2014 08:30, Anthony Petrov wrote: Hi Alexey, The fix looks fine. -- best regards, Anthony On 8/28/2014 11:29 AM, Alexey Ivanov wrote: Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.

Re: Review Request for 8039749: Migrate needed functionality from all subclasses of java.awt.Robot in jdk/test directory to the ancestor

2014-08-28 Thread Anthony Petrov
Hi Dmitriy, Yuri, On 8/27/2014 4:54 PM, Yuri Nesterenko wrote: On 08/27/2014 04:25 PM, Dmitriy Ermashov wrote: At first, let me focus on fact that the actual motivation of moving functionality to java.awt.Robot is the Jigsaw project. We (SQE) will be unable to use internal java API after the pr

Re: [7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Anthony Petrov
Hi Alexey, The fix looks fine. -- best regards, Anthony On 8/28/2014 11:29 AM, Alexey Ivanov wrote: Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.openjdk.java.net/~aivanov/8056156/jdk7/webrev.00/ JBS: https://bugs.

[7u-dev] Request for Approval and Review: 8056156: [TEST_BUG] Test javax/swing/JFileChooser/8046391/bug8046391.java fails in Windows

2014-08-28 Thread Alexey Ivanov
Hello, Could you please approve the fix of the test in jdk7u-dev? Could you please review the fix? webrev: http://cr.openjdk.java.net/~aivanov/8056156/jdk7/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8056156 Description: The test fails to compile under jdk7 because of lambda e