Re: The path to flavormap.properties is currently broken in SystemFlavorMap

2014-09-02 Thread Ludovic HOCHET
Hello Alexander, Thanks for the additional explanation. Good to see the datatransfer API becoming autonomous. Best Regards, Ludovic On Tue, Sep 2, 2014 at 5:13 PM, Alexander Zvegintsev wrote: > Hello Ludovic, > > Addition of "resources" is widely used at least in the OpenJDK project. > You can e

Re: [9] Review request for 6624085: Fourth mouse button (wheel) is treated like second button - isPopupTrigger returns true

2014-09-02 Thread Alex Henrie
Thank you for pushing my patch to JDK 9! Can this fix be backported to Java 8 and Java 7 as well? The diff below applies cleanly to jdk8u-dev/jdk and jdk7u-dev/jdk. -Alex diff --git a/src/solaris/classes/sun/awt/X11/XWindow.java b/src/solaris/classes/sun/awt/X11/XWindow.java --- a/src/solaris/cl

Re: The path to flavormap.properties is currently broken in SystemFlavorMap

2014-09-02 Thread Alexander Zvegintsev
Hello Ludovic, Addition of "resources" is widely used at least in the OpenJDK project. You can easily check it by finding "*.properties" files over sources directory. As for flavormap.properties files movement in general: JDK-8051449 [1] is one of the transitional steps to separate java.awt.dat

Re: [9] Review request for 8055746 : plenty of clipboard/dnd tests fail and break X11

2014-09-02 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/1/2014 4:55 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8055746/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8055746 This is a merge issue. JDK-8051449 [2] was pushe

Re: [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

2014-09-02 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/2/2014 3:09 PM, Alexey Ivanov wrote: Hello AWT team, This is a reminder, Is there any volunteer to review this fix? Thanks, Alexey. On 29.08.2014 12:20, Alexey Ivanov wrote: Hello AWT Team, Could you please review the fix for bug:

Re: [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

2014-09-02 Thread Alexey Ivanov
Petr, Alexander, Thank you for your review. Regards, Alexey. On 02.09.2014 15:47, Alexander Zvegintsev wrote: Hello Alexey, the fix looks good to me too. Thanks, Alexander. On 09/02/2014 03:31 PM, Petr Pchelko wrote: Hello, Alexey. The fix looks good to me. With best regards. Petr. On

Re: [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

2014-09-02 Thread Alexander Zvegintsev
Hello Alexey, the fix looks good to me too. Thanks, Alexander. On 09/02/2014 03:31 PM, Petr Pchelko wrote: Hello, Alexey. The fix looks good to me. With best regards. Petr. On Sep 2, 2014, at 3:09 PM, Alexey Ivanov wrote: Hello AWT team, This is a reminder, Is there any volunteer to r

Re: [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

2014-09-02 Thread Petr Pchelko
Hello, Alexey. The fix looks good to me. With best regards. Petr. > On Sep 2, 2014, at 3:09 PM, Alexey Ivanov wrote: > > Hello AWT team, > > This is a reminder, > > Is there any volunteer to review this fix? > > Thanks, > Alexey. > > On 29.08.2014 12:20, Alexey Ivanov wrote: >> Hello AWT T

Re: [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

2014-09-02 Thread Alexey Ivanov
Hello AWT team, This is a reminder, Is there any volunteer to review this fix? Thanks, Alexey. On 29.08.2014 12:20, Alexey Ivanov wrote: Hello AWT Team, Could you please review the fix for bug: bug: https://bugs.openjdk.java.net/browse/JDK-8056211 webrev: http://cr.openjdk.java.net/~

Re: [9] Review request for 8055746 : plenty of clipboard/dnd tests fail and break X11

2014-09-02 Thread Petr Pchelko
Hi, Alexander. The fix looks good to me. Thanks for taking care of this/ With best regards. Petr. > On Sep 1, 2014, at 4:55 PM, Alexander Zvegintsev > wrote: > > Hello, > > please review the fix > http://cr.openjdk.java.net/~azvegint/jdk/9/8055746/00/ > for the issue > https://bugs.openjdk.j

Re: Review Request for 8051716: Move AWT_BAT functional tests to OpenJDK (1 of 3)

2014-09-02 Thread Dmitriy Ermashov
Hi, Just a kindly reminder. Thanks, Dima On 08/12/2014 05:35 PM, Dmitriy Ermashov wrote: Hi AWT team, Could anyone please review the tests? http://cr.openjdk.java.net/~dermashov/8051716/webrev.01/ Corresponding bug: https://bugs.openjdk.java.net/browse/JDK-8051716 The tests were taken from