[9] Review Request: JDK-8058805 Fix type in client-related package for tray.policy file missing in java/awt/TrayIcon/SecurityCheck/NoPermissionTest

2014-09-19 Thread pooja chopra
|Hello, | || |Please review a fix ||for| |the issue: | || |8058805| |[TEST_BUG] java/awt/TrayIcon/SecurityCheck/NoPermissionTest||/|||NoPermissionTest.java| fails with Cant find Policy file error.||| || |Test bug fix. | || |https://bugs.openjdk.java.net/browse/JDK-8058805||| || | The webrev is:

[9] Review Request: 8058635 Fix type in client-related package for Compilation fail in sun/awt/datatransfer/SuplementaryCharactersTransferTest.java

2014-09-19 Thread pooja chopra
|Hello, | || |Please review a fix ||for| |the issue: | || |8058635| |[TEST_BUG] ||sun/awt/datatransfer/SuplementaryCharactersTransferTest.java fails with Compilation error ||| || |Test bug fix. | || |https://bugs.openjdk.java.net/browse/JDK-8058635||| || |The webrev is: http://cr.openjdk.java.n

Re: RFR: 8056216 : Remove "sun" directory layer from libawt and common

2014-09-19 Thread Seán Coffey
On 19/09/14 17:33, Alan Bateman wrote: On 19/09/2014 17:22, Phil Race wrote: Gosh that's going to be a pain to maintain .. here's an update to the 334 affected lines in that file ! Look ok ? http://cr.openjdk.java.net/~prr/8056216.1 -phil Ideally there should be just one line per directory,

Re: RFR: 8056216 : Remove "sun" directory layer from libawt and common

2014-09-19 Thread Alan Bateman
On 19/09/2014 17:22, Phil Race wrote: Gosh that's going to be a pain to maintain .. here's an update to the 334 affected lines in that file ! Look ok ? http://cr.openjdk.java.net/~prr/8056216.1 -phil Ideally there should be just one line per directory, it should only list individual files for

Re: RFR: 8056216 : Remove "sun" directory layer from libawt and common

2014-09-19 Thread Phil Race
Gosh that's going to be a pain to maintain .. here's an update to the 334 affected lines in that file ! Look ok ? http://cr.openjdk.java.net/~prr/8056216.1 -phil On 09/19/2014 03:37 AM, Seán Coffey wrote: Hi Phil, you'll need to update the unshuffle script[1] also given your path changes. A

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

2014-09-19 Thread mikhail cherkasov
Hi there! Just friendly reminder about this review request. Thanks, Mikhail. On 9/16/2014 3:39 PM, mikhail cherkasov wrote: Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8038919/webrev.01/ bug: https://bugs.openjdk.java.net/browse/JDK-8038919 The problem appears if w

Re: [9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

2014-09-19 Thread Sergey Bylokhov
Hi, Anton. Then the fix looks good, thanks for clarification. On 19.09.2014 17:25, anton nashatyrev wrote: We don't treat the 'text/plain; class=java.lang.Object' as TextType (DataFlavor.isFlavorTextType()) since it has unknown representation class. Such flavors fall into 'other' category. On

Re: [9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

2014-09-19 Thread anton nashatyrev
We don't treat the 'text/plain; class=java.lang.Object' as TextType (DataFlavor.isFlavorTextType()) since it has unknown representation class. Such flavors fall into 'other' category. On 19.09.2014 17:16, Sergey Bylokhov wrote: Hi, Anton. Why "unknown/flavor" is before "text/plain" in the fixe

Re: [9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

2014-09-19 Thread Sergey Bylokhov
Hi, Anton. Why "unknown/flavor" is before "text/plain" in the fixed version? text/plain; class=java.io.Serializable; charset=unicode text/html; class=java.io.Serializable; charset=unicode unknown/flavor; class=java.io.InputStream unknown/flavor; class=java.lang.Object text/unknown; class=java.lan

[9] Review Request for 8055836: move awt tests from AWT_Modality to OpenJDK repository - part 9

2014-09-19 Thread alexander stepanov
Hello, Could you please review the fix for https://bugs.openjdk.java.net/browse/JDK-8055836 webrev: http://cr.openjdk.java.net/~avstepan/8055836/ This is the result of refactoring for corresponding portion of functional AWT tests. The test was checked on Windows 7, Solaris 11, Mac OS X 10.8.

Re: [9] Review request for 8058473: "Comparison method violates its general contract" when using Clipboard

2014-09-19 Thread anton nashatyrev
Hi Sergey, On 18.09.2014 17:30, Sergey Bylokhov wrote: - Can you try to change sort TimSort algorithm to mergerSort. What the order will be in this case ?(see JDK-8048887). The mergeSort seems to be more relaxed regarding the Comparator correctness (BTW TimSort also doesn't fail each time -

Re: RFR: 8056216 : Remove "sun" directory layer from libawt and common

2014-09-19 Thread Seán Coffey
Hi Phil, you'll need to update the unshuffle script[1] also given your path changes. A find/replace operation should work. It probably makes sense to push all changes together. Regards, Sean. [1] http://cr.openjdk.java.net/~chegar/docs/portingScript.html On 19/09/14 09:28, Magnus Ihse Bursi

Re: RFR: 8056216 : Remove "sun" directory layer from libawt and common

2014-09-19 Thread Magnus Ihse Bursie
On 2014-09-18 22:42, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8056216 http://cr.openjdk.java.net/~prr/8056216/ Looks good to me. Thanks! /Magnus This is all just removing the sequence "sun/" from various pathnames. Aside from the make file changes there are over 600 file m

Re: RFR: 8056216 : Remove "sun" directory layer from libawt and common

2014-09-19 Thread Erik Joelsson
Looks good to me. Thanks for fixing this! /Erik On 2014-09-18 22:42, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8056216 http://cr.openjdk.java.net/~prr/8056216/ This is all just removing the sequence "sun/" from various pathnames. Aside from the make file changes there are over