Looks good to me. Thanks for fixing this!
/Erik
On 2014-09-18 22:42, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8056216
http://cr.openjdk.java.net/~prr/8056216/
This is all just removing the sequence sun/ from various pathnames.
Aside from the make file changes there are over
On 2014-09-18 22:42, Phil Race wrote:
https://bugs.openjdk.java.net/browse/JDK-8056216
http://cr.openjdk.java.net/~prr/8056216/
Looks good to me. Thanks!
/Magnus
This is all just removing the sequence sun/ from various pathnames.
Aside from the make file changes there are over 600 file
Hi Phil,
you'll need to update the unshuffle script[1] also given your path
changes. A find/replace operation should work. It probably makes sense
to push all changes together.
Regards,
Sean.
[1] http://cr.openjdk.java.net/~chegar/docs/portingScript.html
On 19/09/14 09:28, Magnus Ihse
Hi Sergey,
On 18.09.2014 17:30, Sergey Bylokhov wrote:
- Can you try to change sort TimSort algorithm to mergerSort. What
the order will be in this case ?(see JDK-8048887).
The mergeSort seems to be more relaxed regarding the Comparator
correctness (BTW TimSort also doesn't fail each time
Hi, Anton.
Why unknown/flavor is before text/plain in the fixed version?
text/plain; class=java.io.Serializable; charset=unicode
text/html; class=java.io.Serializable; charset=unicode
unknown/flavor; class=java.io.InputStream
unknown/flavor; class=java.lang.Object
text/unknown;
Hi, Anton.
Then the fix looks good, thanks for clarification.
On 19.09.2014 17:25, anton nashatyrev wrote:
We don't treat the 'text/plain; class=java.lang.Object' as TextType
(DataFlavor.isFlavorTextType()) since it has unknown representation
class. Such flavors fall into 'other' category.
Hi there!
Just friendly reminder about this review request.
Thanks,
Mikhail.
On 9/16/2014 3:39 PM, mikhail cherkasov wrote:
Hello all,
please review the fix
http://cr.openjdk.java.net/~mcherkas/8038919/webrev.01/
bug: https://bugs.openjdk.java.net/browse/JDK-8038919
The problem appears if
Gosh that's going to be a pain to maintain .. here's an update to the
334 affected lines in that file ! Look ok ?
http://cr.openjdk.java.net/~prr/8056216.1
-phil
On 09/19/2014 03:37 AM, Seán Coffey wrote:
Hi Phil,
you'll need to update the unshuffle script[1] also given your path
changes.
On 19/09/2014 17:22, Phil Race wrote:
Gosh that's going to be a pain to maintain .. here's an update to the
334 affected lines in that file ! Look ok ?
http://cr.openjdk.java.net/~prr/8056216.1
-phil
Ideally there should be just one line per directory, it should only list
individual files
On 19/09/14 17:33, Alan Bateman wrote:
On 19/09/2014 17:22, Phil Race wrote:
Gosh that's going to be a pain to maintain .. here's an update to the
334 affected lines in that file ! Look ok ?
http://cr.openjdk.java.net/~prr/8056216.1
-phil
Ideally there should be just one line per directory,
|Hello, |
||
|Please review a fix ||for| |the issue: |
||
|8058635| |[TEST_BUG]
||sun/awt/datatransfer/SuplementaryCharactersTransferTest.java fails
with Compilation error
|||
||
|Test bug fix.
|
||
|https://bugs.openjdk.java.net/browse/JDK-8058635|||
||
|The webrev is:
|Hello, |
||
|Please review a fix ||for| |the issue: |
||
|8058805| |[TEST_BUG]
java/awt/TrayIcon/SecurityCheck/NoPermissionTest||/|||NoPermissionTest.java|
fails with Cant find Policy file error.|||
||
|Test bug fix.
|
||
|https://bugs.openjdk.java.net/browse/JDK-8058805|||
||
|
The webrev
12 matches
Mail list logo
