Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

2014-10-02 Thread Sergey Bylokhov
Hi, Mikhail. The fix looks good. On 02.10.2014 17:18, mikhail cherkasov wrote: oh sorry about this, I forgot to remove this code, it was used for debug purposes only. there is correct version: http://cr.openjdk.java.net/~mcherkas/8038919/webrev.03/src/java.desktop/macosx/classes/sun/lwawt/macos

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

2014-10-02 Thread mikhail cherkasov
oh sorry about this, I forgot to remove this code, it was used for debug purposes only. there is correct version: http://cr.openjdk.java.net/~mcherkas/8038919/webrev.03/src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java.udiff.html On 10/2/2014 5:02 PM, Sergey Bylokhov wrote:

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

2014-10-02 Thread Sergey Bylokhov
Hi, Mikhail. Why this code is needed in CPlatformWindow.java? "Container parent = getPeer().getTarget().getParent()" note that getPeer() can return null. On 01.10.2014 15:19, mikhail cherkasov wrote: Hi there, it's just friendly reminder about this review request. Thanks, Mikhail. On 9/25/2