Re: [9] Review request : 8062021 NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146

2014-10-24 Thread Anton V. Tarasov
Looks fine for me. Regards, Anton. On 24.10.2014 16:01, mikhail cherkasov wrote: Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8062021/webrev.00/ bug: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 https://bugs.openjdk.java.net/browse/JDK-8062021 C

[9] Review request : 8062021 NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146

2014-10-24 Thread mikhail cherkasov
Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8062021/webrev.00/ bug: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 https://bugs.openjdk.java.net/browse/JDK-8062021 Check for null was added. Thanks, Mikhail.

Re: [9] Review request : 8038919, Requesting focus to a modeless dialog doesn't work on Safari

2014-10-24 Thread Anton V. Tarasov
On 22.10.2014 17:08, Sergey Bylokhov wrote: Hi, Mikhail. As I said before, window.getPeer() can return null in some cases. After this fix some tests fail with NPE: ex: closed/java/awt/Frame/DisposeStressTest Please fix. Sergey, you're right. Disposing happens synchronously unlike focus handli