Re: [7u-dev] Request for Approval and Review: 8057008: [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error

2014-10-27 Thread Anton V. Tarasov
Please, disregard my approval for the wrong webrev. Please, see the upcoming message. Anton. On 27.10.2014 18:44, Anton V. Tarasov wrote: Hi Srinivasan, The fix looks fine for me. Regards, Anton. On 01.09.2014 20:33, srinivasan raghavan wrote: Hello , Please review a fix for the issue 80

Re: [7u-dev] Request for Approval and Review: 8057008: [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error

2014-10-27 Thread Anton V. Tarasov
Looks fine. Regards, Anton. On 01.09.2014 20:42, srinivasan raghavan wrote: Hello , Apologies for giving wrong web-rev link i am updating with the new one The webrev is http://cr.openjdk.java.net/~kshefov/8057008/webrev.00/ -Thanks Srinivasan Raghavan On 9/1/2014 10:03 PM, srinivasan raghava

Re: [7u-dev] Request for Approval and Review: 8057008: [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error

2014-10-27 Thread Anton V. Tarasov
Hi Srinivasan, The fix looks fine for me. Regards, Anton. On 01.09.2014 20:33, srinivasan raghavan wrote: Hello , Please review a fix for the issue 8057008 [TEST_BUG] Test java/awt/Focus/SortingFPT/JDK8048887.java fails with compilation error Test bug fix https://bugs.openjdk.java.net/bro

Re: [9] Review request : 8062021 NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146

2014-10-27 Thread Sergey Bylokhov
HI, Mikhail. The fix looks good. On 24.10.2014 16:01, mikhail cherkasov wrote: Hello all, please review the fix http://cr.openjdk.java.net/~mcherkas/8062021/webrev.00/ bug: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 https://bugs.openjdk.java.net/browse/JDK-8062021 Chec

[9] Review Request for 8054358: move awt automated tests from AWT_Modality to OpenJDK repository - part 7

2014-10-27 Thread alexander stepanov
Hello, Could please anyone review this old request? Thanks, Alexander On 25.09.2014 17:10, alexander stepanov wrote: Sorry, just a reminder. Thanks, Alexander On 11.09.2014 18:27, alexander stepanov wrote: Could anyone review this old request? Thanks, Alexander On 15.08.2014 12:19, alexan

[9] Review Request for 8054143: move awt automated tests from AWT_Modality to OpenJDK repository - part 6

2014-10-27 Thread alexander stepanov
Hello, Could please anyone review this old request? Thanks, Alexander On 25.09.2014 17:06, alexander stepanov wrote: Just a reminder. Thanks, Alexander On 11.09.2014 18:29, alexander stepanov wrote: Sorry, just a reminder. Thanks, Alexander On 05.09.2014 17:20, alexander stepanov wrote:

[9] Review Request for 8054359: move awt automated tests from AWT_Modality to OpenJDK repository - part 8

2014-10-27 Thread alexander stepanov
Hello, Could please anyone review this old request? Thanks, Alexander On 25.09.2014 17:08, alexander stepanov wrote: Sorry, just a reminder. Thanks, Alexander On 12.09.2014 15:08, alexander stepanov wrote: Hello Alexandr, Fixed; please see the updated webrev: http://cr.openjdk.java.net/~av

Re: [9] Review Request for 8055836: move awt tests from AWT_Modality to OpenJDK repository - part 9

2014-10-27 Thread alexander stepanov
Hello, Could please anyone review this old request? Thanks, Alexander On 24.09.2014 17:08, alexander stepanov wrote: Hello Sergey, Thanks, fixed: http://cr.openjdk.java.net/~avstepan/8055836/webrev.01/ Regards, Alexander On 23.09.2014 18:58, Sergey Bylokhov wrote: Hi, Alexander. PrintDialo