[9] Review request for 8063102: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 1

2014-11-07 Thread Yuri Nesterenko
Colleagues, please review the first batch of 34 regression tests modified to eliminate internal references (mostly to realSync but not only). Several closed tests moved in the open. Change: http://cr.openjdk.java.net/~yan/8063102/webrev.00 removal diff: http://cr.openjdk.java.net/~yan/8063102/w

[9] Review Request for JDK-8004148: NPE in sun.awt.SunToolkit.getWindowDeactivationTime

2014-11-07 Thread Anton V. Tarasov
Hello, Please, review the fix. https://bugs.openjdk.java.net/browse/JDK-8004148 http://cr.openjdk.java.net/~ant/JDK-8004148/webrev.0 There's no a test case for the original issue. However, there's another test case which reproduces NPE with the same stack trace. The problem was fixed in jdk8 i

Re: [7u] Review request for 8061954: 7u76 - deployment warning dialogs do not work on Linux

2014-11-07 Thread Sergey Bylokhov
The fix looks fine to me too. On 07.11.2014 12:20, Anton V. Tarasov wrote: On 07.11.2014 13:45, Anton Litvinov wrote: Hello Anton, Thank you for the response. I would just like to clarify one question. Did you approve this version of the fix? Yes, sure, I approved. Thanks, Anton. Thank

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-11-07 Thread Sergey Bylokhov
On 07.11.2014 12:48, Dmitriy Ermashov wrote: Hi Sergey, Most of them fails on OS X 10.10 because of https://bugs.openjdk.java.net/browse/JDK-8013450. java/awt/Window/ShapedAndTranslucentWindows/FocusAWTTest.java test is marked with corresponding @bug tag. Others fails because of different sh

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

2014-11-07 Thread Dmitriy Ermashov
Hi Sergey, Most of them fails on OS X 10.10 because of https://bugs.openjdk.java.net/browse/JDK-8013450. java/awt/Window/ShapedAndTranslucentWindows/FocusAWTTest.java test is marked with corresponding @bug tag. Others fails because of different shadows rendering on new OS X and should be fix

Re: [7u] Review request for 8061954: 7u76 - deployment warning dialogs do not work on Linux

2014-11-07 Thread Anton V. Tarasov
On 07.11.2014 13:45, Anton Litvinov wrote: Hello Anton, Thank you for the response. I would just like to clarify one question. Did you approve this version of the fix? Yes, sure, I approved. Thanks, Anton. Thank you, Anton On 11/7/2014 10:48 AM, Anton V. Tarasov wrote: Hi Anton, On 06.

Re: [7u] Review request for 8061954: 7u76 - deployment warning dialogs do not work on Linux

2014-11-07 Thread Anton Litvinov
Hello Anton, Thank you for the response. I would just like to clarify one question. Did you approve this version of the fix? Thank you, Anton On 11/7/2014 10:48 AM, Anton V. Tarasov wrote: Hi Anton, On 06.11.2014 19:38, Anton Litvinov wrote: Hello Anton, Thank you for the review of the fi

Re: [7u] Review request for 8061954: 7u76 - deployment warning dialogs do not work on Linux

2014-11-07 Thread Anton V. Tarasov
Hi Anton, On 06.11.2014 19:38, Anton Litvinov wrote: Hello Anton, Thank you for the review of the fix. Yes, automatic jtreg regression tests from the directories listed in my review request were launched. Debugging of the issue showed that, as you said, AppContext equals null, because the th