Re: [9] Review Request: 8057788 [macosx] "Pinch to zoom" does not work since jdk7

Hello, Denis. Just one question: did you add this only to AWTWindow_Normal and not to AWTWindow_Panel intentionally? Why? Will the feature still work in undecorated frames? With best regards. Petr. > On Nov 10, 2014, at 5:04 PM, Denis S. Fokin wrote: > > Hi Sergey, > > Thank you for the revi

Re: [9] Review Request: 8057788 [macosx] "Pinch to zoom" does not work since jdk7

Yes, please, wait a second review. On 10.11.2014 17:04, Denis S. Fokin wrote: Hi Sergey, Thank you for the review. Do I need another reviewer to push? Thank you, Denis. On 10 Nov 2014, at 15:12, Sergey Bylokhov > wrote: Hi, Denis. The fix looks

Will fix be backported?

Hey... How can I check whether a fix is being backported to JDK8? E.g. https://bugs.openjdk.java.net/browse/JDK-8043869 only lists emb-9 under backports. Does that mean it's not being backported to 8? Thank you, -hendrik

Re: [9] Review Request for 8054143: move awt automated tests from AWT_Modality to OpenJDK repository - part 6

Hello, Alexander. test/java/awt/Modal/ToBack/ToBackDDFTest.java - setModal should be volatile or final - rightFrameOverlapsDialog: what's 7? why is it 7? I think it's better to calculate the center of the frame in case the size of window decorations will be changed in some OS version. line 146:

Re: [9] Review Request for 8055836: move awt tests from AWT_Modality to OpenJDK repository - part 9

Hello Petr, Thanks! Regards, Alexander On 10.11.2014 17:26, Petr Pchelko wrote: Hello, Alexander. The fix looks fine. With best regards. Petr. On 27 окт. 2014 г., at 14:24, alexander stepanov wrote: Hello, Could please anyone review this old request? Thanks, Alexander On 24.09.2014 1

Re: [9] Review Request for 8055836: move awt tests from AWT_Modality to OpenJDK repository - part 9

Hello, Alexander. The fix looks fine. With best regards. Petr. On 27 окт. 2014 г., at 14:24, alexander stepanov wrote: > Hello, > > Could please anyone review this old request? > > Thanks, > Alexander > > On 24.09.2014 17:08, alexander stepanov wrote: >> Hello Sergey, >> >> Thanks, fixed:

Re: [9] Review Request: 8057788 [macosx] "Pinch to zoom" does not work since jdk7

Hi Sergey, Thank you for the review. Do I need another reviewer to push? Thank you, Denis. > On 10 Nov 2014, at 15:12, Sergey Bylokhov wrote: > > Hi, Denis. > The fix looks fine. > Updated webrev for the current jdk layout: > http://cr.openjdk.java.net/~serb/denis/8057788/webrev.00

Re: [9] Review request for 8063102: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 1

Hi, The fix looks fine. On 10.11.2014 11:15, Petr Pchelko wrote: Hello, Yuri. As long as the classpath hack will be fixed in a separate bug, This fix looks good to me. With best regards. Petr. On 07 нояб. 2014 г., at 20:15, Yuri Nesterenko wrote: Colleagues, please review the first batc

Re: Review request for JDK-8043131: Move ShapedAndTranslucentWindows and GC functional AWT tests to regression tree

These tests have been failing previously: java/awt/Window/ShapedAndTranslucentWindows/FocusAWTTest.java java/awt/Window/ShapedAndTranslucentWindows/SetShapeAndClick.java java/awt/Window/ShapedAndTranslucentWindows/SetShapeDynamicallyAndClick.java java/awt/Window/ShapedAndTranslucentWindows/ShapedT

Re: [9] Review Request for JDK-8004148: NPE in sun.awt.SunToolkit.getWindowDeactivationTime

Hi, Anton. The fix looks good. On 07.11.2014 17:13, Anton V. Tarasov wrote: Hello, Please, review the fix. https://bugs.openjdk.java.net/browse/JDK-8004148 http://cr.openjdk.java.net/~ant/JDK-8004148/webrev.0 There's no a test case for the original issue. However, there's another test case w

Re: [9] Review Request: 8057788 [macosx] "Pinch to zoom" does not work since jdk7

Hi, Denis. The fix looks fine. Updated webrev for the current jdk layout: http://cr.openjdk.java.net/~serb/denis/8057788/webrev.00 On 08.09.2014 16:12, Denis Fokin wrote: Hi AWT team, I know a lot of people who miss “pinch to zoom” feature in Java. It is implemented for jdk 6 but the functiona

Re: [9] Review request for 8063102: Change open awt regression tests to avoid sun.awt.SunToolkit.realSync, part 1

Hello, Yuri. As long as the classpath hack will be fixed in a separate bug, This fix looks good to me. With best regards. Petr. On 07 нояб. 2014 г., at 20:15, Yuri Nesterenko wrote: > Colleagues, > > please review the first batch of 34 regression tests > modified to eliminate internal refer