Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8066621: Suppress deprecation warnings in java.desktop module

2014-12-12 Thread joe darcy
Hi Phil, On 12/12/2014 12:46 PM, Phil Race wrote: Hi, You did not provide a direct reference to the set of warnings that were generated. fortunately I found it here :- https://bugs.openjdk.java.net/browse/JDK-8066622 Each "Suppress deprecations warnings in foo" bug is linked to a "Fix depre

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8066621: Suppress deprecation warnings in java.desktop module

2014-12-12 Thread Phil Race
Hi, You did not provide a direct reference to the set of warnings that were generated. fortunately I found it here :- https://bugs.openjdk.java.net/browse/JDK-8066622 A couple of things I find 'unfortunate' are 1) In order to avoid a deprecation warning on one call/line of a 100 line method,

Re: The input method handling

2014-12-12 Thread Naoto Sato
What I meant by that is the "porting" part of the code, not the Apple JDK itself. IIRC, the initial porting from Apple JDK to Oracle JDK was done by folks at Apple, and that piece of comment was included since the initial port: https://bugs.openjdk.java.net/browse/JDK-7113349 Naoto On 12/12/

Re: [7] Review Request: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text.

2014-12-12 Thread mikhail cherkasov
Hi Sergey, MSExtraDataTransfer passed. Thanks Mikhail. On 12/12/2014 6:26 PM, Sergey Bylokhov wrote: Hi, Mikhail. Can you try this test also: AWT_DnD/Clipboard/Manual/MSExtraDataTransfer And confirm that steps at the end of https://bugs.openjdk.java.net/browse/JDK-2215341 still works. On 12

Re: [7] Review Request: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text.

2014-12-12 Thread Sergey Bylokhov
Hi, Mikhail. Can you try this test also: AWT_DnD/Clipboard/Manual/MSExtraDataTransfer And confirm that steps at the end of https://bugs.openjdk.java.net/browse/JDK-2215341 still works. On 12.12.2014 18:13, mikhail cherkasov wrote: Hi all, One of our customer faced with the following issue: 8

[7] Review Request: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text.

2014-12-12 Thread mikhail cherkasov
Hi all, One of our customer faced with the following issue: 8032964 When using an HTML data flavor, pasting non-Latin char into an applet the "start and end fragment" surrounds text. https://bugs.openjdk.java.net/browse/JDK-8032964 I noticed that jdk8 doesn't have this problem, after some inve

Re: [9] Review Request: 7077826 Unset and empty DISPLAY variable is handled differently by JDK

2014-12-12 Thread Sergey Bylokhov
Hi, Artem. Thanks for review! The new version: http://cr.openjdk.java.net/~serb/7077826/webrev.01 On 10.12.2014 16:53, Artem Ananiev wrote: Hi, Sergey, the fix looks fine to me as well. Just a few cosmetic comments: 1. When we don't care about return value, we usually use PrivilegedAction, no

Re: [9] Review request for 7155963: Deadlock in SystemFlavorMap.getFlavorsForNative and SunToolkit.awtLock

2014-12-12 Thread Anton V. Tarasov
Hi Alexander, The fix looks fine for me. Regards Anton. On 11.12.2014 15:06, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/7155963/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-7155963 SunClipboard.checkChange() does not requ

Re: The input method handling

2014-12-12 Thread Sergey Malenkov
I'm not sure that this is the Apple's code, because Oracle JDK works slightly different from Apple JDK. On Fri, Dec 12, 2014 at 12:04 AM, Naoto Sato wrote: > Honestly I cannot judge whether that is OK or not, because I don't know the > original intention of the comment I quoted in the previous ma