Re: JNLP with & is good XML but gives Java Console message: The reference to entity must end with the '; ' delimiter

2015-04-09 Thread Burk, Bill
Issue persists in build 10. Interesting note, the message displays twice, even though the JNLP contains only one ampersand (and of course that ampersand is encoded in the JNLP file as &) Downloaded Java 8 Update 60 Build 10 from https://jdk8.java.net/download.html Windows 7 Professional Servi

Re: [9] Review request for 8065739 [macosx] Frame warps to lower left of screen when displayed

2015-04-09 Thread Alexander Scherbatiy
I have updated the fix a little bit: http://cr.openjdk.java.net/~alexsch/8065739/webrev.01 - maximized sizes are set when window is created if frame state is MAXIMIZED_BOTH However there is a problem with the case: - Frame frame = new Frame(); frame.setExtendedS

Re: RfR JDK-8076552 nightly build break fix

2015-04-09 Thread Lana Steuck
Hi Pete, Sean said 'your fix will go via 8u-dev' - is this the case? Or are we planning on pushing your changes to 8u Master directly (after proper build/test)? Do you have a forest on nfs? (from where I can pull/clone your fixes)? - Lana On 04/08/2015 11:08 AM, Pete Brunet wrote: I confi

Re: RfR JDK-8076552 nightly build break fix

2015-04-09 Thread Pete Brunet
Phil will do the push. I assume it needs to go to 8u-dev. On 4/8/15 1:38 PM, Lana Steuck wrote: > Hi Pete, > > Sean said 'your fix will go via 8u-dev' - is this the case? > > Or are we planning on pushing your changes to 8u Master directly > (after proper build/test)? > > Do you have a forest on

Re: RfR JDK-8076552 nightly build break fix

2015-04-09 Thread Pete Brunet
I confirmed the javadoc is gone, and make docs did not fail. I have yet to submit the JPRT job. Sean/Winston do you want to wait for the 7 JPRT jobs to finish before you approve the push? Phil will have to do the push; my committer status is pending. Pete On 4/8/15 1:00 PM, Phil Race wrote: >

Re: [9] Review Request: JDK-8076151 Fix for Test java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails

2015-04-09 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 4/9/2015 2:35 PM, Alexander Zvegintsev wrote: still looks good to me. Thanks, Alexander. On 04/09/2015 12:03 PM, pooja chopra wrote: Hi Alexander, I have updated the copyright header in TestFontFile.sh. Please find the updated webrev be

Re: [9] Review request for 7042645: Numerous api/java_awt jck tests fail - AWT Assertion Failure on fastdebug ri bundles b138 win7 x86

2015-04-09 Thread Anton V. Tarasov
Hi Semyon, Looks fine to me. Regards, Anton. On 06.04.2015 15:11, Semyon Sadetsky wrote: Hello, Please review fix for JDK9. webrev: http://cr.openjdk.java.net/~ssadetsky/7042645/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-7042645 *ROOT CAUSE: The assertion fails message trigger

Re: [9] Review Request: JDK-8076151 Fix for Test java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails

2015-04-09 Thread Alexander Zvegintsev
still looks good to me. Thanks, Alexander. On 04/09/2015 12:03 PM, pooja chopra wrote: Hi Alexander, I have updated the copyright header in TestFontFile.sh. Please find the updated webrev below :- 8076151 [TEST_BUG] Test java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails Test bu

Re: [9] Review request for 8073453: Focus doesn't move when pressing Shift + Tab keys

2015-04-09 Thread Anton V. Tarasov
Hi Dmitry, Well, the fix seems correct to me. I tried to thought of any possible regressions but nothing came to my mind (let's suppose this was really a mistake in the code). However, wouldn't you like to do the same for swing's SortingFocusTraversalPolicy? And also, include it into the test

Re: [9] Review Request: JDK-8076151 Fix for Test java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails

2015-04-09 Thread pooja chopra
Hi Alexander, I have updated the copyright header in TestFontFile.sh. Please find the updated webrev below :- 8076151 [TEST_BUG] Test java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8076151 The webrev is: http://cr.openjdk.ja