Re: [9] Review request for 8080504: [macosx] SunToolkit.realSync() may hang

2015-06-25 Thread Phil Race
+1 -phil. On 6/25/15 11:52 AM, Sergey Bylokhov wrote: The fix looks fine. Thanks! On 25.06.15 18:51, Anton Nashatyrev wrote: Sergey, Phil thanks for comments! here is the updated version: http://cr.openjdk.java.net/~anashaty/8080504/webrev.01/

Re: [9] Review request for 8080504: [macosx] SunToolkit.realSync() may hang

2015-06-25 Thread Sergey Bylokhov
The fix looks fine. Thanks! On 25.06.15 18:51, Anton Nashatyrev wrote: Sergey, Phil thanks for comments! here is the updated version: http://cr.openjdk.java.net/~anashaty/8080504/webrev.01/ Thanks! Anton. On 25.06.2015 0:

Re: [9] Review request for 8080504: [macosx] SunToolkit.realSync() may hang

2015-06-25 Thread Anton Nashatyrev
Sergey, Phil thanks for comments! here is the updated version: http://cr.openjdk.java.net/~anashaty/8080504/webrev.01/ Thanks! Anton. On 25.06.2015 0:56, Phil Race wrote: On 06/24/2015 12:26 PM, Sergey Bylokhov wrote: Hi,

Re: JDK 9 RFR of JDK-8129822: Define "headful" jtreg keyword

2015-06-25 Thread Alexander Scherbatiy
On 6/25/2015 2:42 AM, joe darcy wrote: Hello, To support the next iteration of tiered testing in JDK 9, with an eye toward running client library tests, please review the patch below which addresses JDK-8129822: Define "headful" jtreg keyword Some test environments are headless, includi

Re: RFR: JDK-8080246 JNLP app cannot be launched due to deadlock

2015-06-25 Thread Alexander Zvegintsev
Hi Daniil, the fix looks good to me too. -- Thanks, Alexander. On 24.06.2015 22:42, Daniil Titov wrote: Hello, Could you, please, review the following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8080246 Webrev : http://cr.openjdk.java.net/~dtitov/8080246.8/

Re: RFR: JDK-8080246 JNLP app cannot be launched due to deadlock

2015-06-25 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 6/24/2015 10:42 PM, Daniil Titov wrote: Hello, Could you, please, review the following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8080246 Webrev : http://cr.openjdk.java.net/~dtitov/8080246.8/