Re: [9] Review Request for 8085948: [Regression] Few Swing, AWT and 2D case fails with Decoder isn't implemented for WingDings Charset error on Windows

+1 -phil. On 6/11/15 9:19 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8085948 webrev: http://cr.openjdk.java.net/~ssadetsky/8085948/webrev.00/ It is a regression of JDK-8035302. The charset name is requested from a dummy stream

Re: [9, 8] Review request for 8081485: EDT auto shutdown is broken in case of new event queue usage

Hi, Anton. The fix looks fine. On 01.07.15 16:07, Anton Nashatyrev wrote: Hello Artem, Sergey thanks for your help with the issue investigation! could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8081485/webrev.00/

Re: [9] Review request for 8081787: [macosx] MalformedURLException is thrown during reading data for application/x-java-url; class=java.net.URL flavor

Hi, Mikhail. The test will be useful, at least for verification. On my osx for example the test from the bug description fails with UnsupportedFlavorException: application/x-java-url On 01.07.15 14:27, mikhail cherkasov wrote: Hi there, Could you please review a fix for: 8081787 [macosx] Mal

Re: [9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

Hi, could you please take a look at the 2nd version: http://cr.openjdk.java.net/~yan/8130125/webrev.01 Bug is here: https://bugs.openjdk.java.net/browse/JDK-8130125 Thanks, -yan On 07/02/2015 04:50 PM, Yuri Nesterenko wrote: On 07/02/2015 03:57 PM, Sergey Bylokhov wrote: Hi, Yuri. - bug6

Re: [9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

On 07/02/2015 03:57 PM, Sergey Bylokhov wrote: Hi, Yuri. - bug6980209.java can use some public logging? - FocusEmbeddedFrameTest/ JButtonInGlassPaneOverlapping/etc why it needs a peer? It's UtilInternal needs it, and that helper should be fixed in Jake by addExports. - JSplitPaneOverlapp

Re: [9] Review Request: JDK-8081361 [TEST_BUG] Test java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest fails

The fix looks good to me. It would be useful to check that the fix that causes the change of the JTextField size made it by purposes and not as side effect. Thanks, Alexander. On 6/30/2015 12:26 PM, pooja chopra wrote: Hi Alexander, I fixed the test to match the spec as mentioned

Re: [9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

Hi, Yuri. - bug6980209.java can use some public logging? - FocusEmbeddedFrameTest/ JButtonInGlassPaneOverlapping/etc why it needs a peer? - JSplitPaneOverlapping please split the long description - bug6608456 why it needs com.sun.java.swing? On 02.07.15 13:55, Yuri Nesterenko wrote: Collea

Re: [9] Review Request: JDK-8080932 [TEST_BUG] Test java/awt/BasicStroke/DashStrokeTest.java fails with Bad script error due to improper @run notation

Hi, you already have two reviewers, it is sufficient to push. Anyway, the fix looks good to me. Thanks, Alexander. On 07/02/2015 10:28 AM, pooja chopra wrote: Hi All, Please review below fix. Regards, Pooja On 6/17/2015 12:05 PM, pooja chopra wrote: Hi All, Gentle reminder .Please review bel

Re: [9] Review Request: JDK-8080953 [TEST_BUG]Test java/awt/FontClass/DebugFonts.java fails due to wrongly typed bugid

+1 On 02.07.15 14:41, Alexander Zvegintsev wrote: Looks fine to me. Thanks, Alexander. On 07/02/2015 10:29 AM, pooja chopra wrote: Hi All, Please review below fix. Regards, Pooja On 6/17/2015 12:06 PM, pooja chopra wrote: Hi All , Gentle Reminder. Please review below fix . Regards, Pooja O

Re: [9] Review Request: JDK-8080953 [TEST_BUG]Test java/awt/FontClass/DebugFonts.java fails due to wrongly typed bugid

Looks fine to me. Thanks, Alexander. On 07/02/2015 10:29 AM, pooja chopra wrote: Hi All, Please review below fix. Regards, Pooja On 6/17/2015 12:06 PM, pooja chopra wrote: Hi All , Gentle Reminder. Please review below fix . Regards, Pooja On 5/22/2015 10:34 PM, Sergey Bylokhov wrote: cc 2d

[9] Review Request for 8130125: [TEST_BUG] add @modules to the several client tests unaffected by the automated bulk update

Colleagues, please review this test change: http://cr.openjdk.java.net/~yan/8130125/webrev.00/ In the most of the tests just @modules directive added; other than that, see a short comment in https://bugs.openjdk.java.net/browse/JDK-8130125 Also I'd like to piggyback in the push 3 tests moved fr

Re: [9] Review Request: JDK-8080953 [TEST_BUG]Test java/awt/FontClass/DebugFonts.java fails due to wrongly typed bugid

Hi All, Please review below fix. Regards, Pooja On 6/17/2015 12:06 PM, pooja chopra wrote: Hi All , Gentle Reminder. Please review below fix . Regards, Pooja On 5/22/2015 10:34 PM, Sergey Bylokhov wrote: cc 2d On 22.05.15 19:59, pooja chopra wrote: Hello, Please review a fix for issue: 8080953

Re: [9] Review Request: JDK-8080932 [TEST_BUG] Test java/awt/BasicStroke/DashStrokeTest.java fails with Bad script error due to improper @run notation

Hi All, Please review below fix. Regards, Pooja On 6/17/2015 12:05 PM, pooja chopra wrote: Hi All, Gentle reminder .Please review below fix . Regards, Pooja On 6/4/2015 8:18 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 6/3/2015 3:50 PM, pooja chopra wro