< Swing Dev> [9] Review Request:JDK-8130481 [TEST_BUG] javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception

2015-07-15 Thread pooja chopra
Hello, Please review a fix for issue :- 8130481 [TEST_BUG] javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8130481 The webrev is : http://cr.openjdk.java.net/~pchopra/8130481/webrev.00/ Regards, P

Re: < Swing Dev> [9] Review Request:JDK-8130481 [TEST_BUG] javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception

2015-07-15 Thread pooja chopra
Hello , Corrected the webrev link below . Please review. Regards, Pooja On 7/15/2015 3:26 PM, pooja chopra wrote: Hello, Please review a fix for issue :- 8130481 [TEST_BUG] javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception Test bug fix. https://bugs.o

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-07-15 Thread Alexander Scherbatiy
On 7/14/2015 3:18 AM, Alan Snyder wrote: I have a concern about how custom multiresolution images are supported based on a problem I ran into using the JDK 8 classes, which are similar. The problem is that the selection of a variant image happens during painting. That is a very bad time to act

Re: [9] Review Request for 8025815: Child FileDialog of modal dialog does not get focus on Gnome

2015-07-15 Thread Semyon Sadetsky
Hi Alexander, In the next version I have updated the test and Sergey's notes are taken into account. http://cr.openjdk.java.net/~ssadetsky/8025815/webrev.01/ --Semyon On 7/13/2015 7:21 PM, Alexander Zvegintsev wrote: Hello Semyon, the fix itself look good to me, but the test seems to be br

Re: [9] Review Request for 8025815: Child FileDialog of modal dialog does not get focus on Gnome

2015-07-15 Thread Alexander Zvegintsev
still looks good to me. Thanks, Alexander. On 07/15/2015 03:59 PM, Semyon Sadetsky wrote: Hi Alexander, In the next version I have updated the test and Sergey's notes are taken into account. http://cr.openjdk.java.net/~ssadetsky/8025815/webrev.01/ --Semyon On 7/13/2015 7:21 PM, Alexander

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-07-15 Thread Alan Snyder
It seems you are making an assumption that the code that creates the image is somehow initiated from a paint method so that the display scale factor can be obtained from the graphics context and used to determine the required image resolution. That is not the scenario I am concerned about. I am

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-07-15 Thread Alexander Scherbatiy
On 7/15/2015 5:09 PM, Alan Snyder wrote: It seems you are making an assumption that the code that creates the image is somehow initiated from a paint method so that the display scale factor can be obtained from the graphics context and used to determine the required image resolution. That is

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-07-15 Thread Alan Snyder
I am commenting on your suggestion that I can determine which display the image will displayed on. > On Jul 15, 2015, at 7:42 AM, Alexander Scherbatiy > wrote: > > On 7/15/2015 5:09 PM, Alan Snyder wrote: >> >> It seems you are making an assumption that the code that creates the image >> i

Re: < Swing Dev> [9] Review Request:JDK-8130481 [TEST_BUG] javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception

2015-07-15 Thread Sergey Bylokhov
Hello, I suggest to check support of systemTray at the beginning of the test. On 15.07.15 13:07, pooja chopra wrote: Hello , Corrected the webrev link below . Please review. Regards, Pooja On 7/15/2015 3:26 PM, pooja chopra wrote: Hello, Please review a fix for issue :- 8130481 [TEST_BUG] j

Re: RfR JDK-8051626 Rework security restrictions of Java Access Bridge and related Utilities

2015-07-15 Thread Pete Brunet
An update is available and mostly changes only the test case, Bug8151626.java. The other change is to remove jtreg.security.policy. http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.01/ Changes: >From Sean - The jtreg @run statement was removed; don't specify security manager or security