Re: AWT Dev RfR JDK-8051626 Rework security restrictions of Java Access Bridge and related Utilities

2015-07-16 Thread Sergey Bylokhov
The fix looks fine. On 16.07.15 0:42, Pete Brunet wrote: An update is available and mostly changes only the test case, Bug8151626.java. The other change is to remove jtreg.security.policy. http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.01/ Changes: From Sean - The jtreg @run

AWT Dev [9] Review Request for 8131673: [TEST_BUG] add @modules to some OS X-specific regtests

2015-07-16 Thread Yuri Nesterenko
Colleagues, please review this test fix for 3 tests reflecting com.apple.eawt. After the fix, they should start with a modular build. Two of them dealing with fullscreen, should now work better on OS X 10.9. I cannot, however, easily fix them for OS X 10.10 where full screen button is in

Re: AWT Dev [9] Review Request for 8131673: [TEST_BUG] add @modules to some OS X-specific regtests

2015-07-16 Thread Sergey Bylokhov
The fix looks fine. On 16.07.15 17:16, Yuri Nesterenko wrote: I cannot, however, easily fix them for OS X 10.10 where full screen button is in different place. Let's make another bug for that. Current CR is https://bugs.openjdk.java.net/browse/JDK-8131673 Webrev is

Re: AWT Dev [9] Review Request for 8131673: [TEST_BUG] add @modules to some OS X-specific regtests

2015-07-16 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 07/16/2015 06:07 PM, Sergey Bylokhov wrote: The fix looks fine. On 16.07.15 17:16, Yuri Nesterenko wrote: I cannot, however, easily fix them for OS X 10.10 where full screen button is in different place. Let's make another bug for that. Current CR is

AWT Dev Awt Dev [9] Review Request for 8130769: The new menu can't be shown on the menubar after clicking the Add button.

2015-07-16 Thread Semyon Sadetsky
Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8130769 webrev: http://cr.openjdk.java.net/~ssadetsky/8130769/webrev.00/ This is regression from JDK-7155957. Menu should be added to MenuBar collection before the adding it to MenuBar's peer otherwise it is not

Re: AWT Dev RfR JDK-8051626 Rework security restrictions of Java Access Bridge and related Utilities

2015-07-16 Thread Pete Brunet
From Mandy: - remove unused imports - add @run main/othervm http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.02/ On 7/15/15 4:42 PM, Pete Brunet wrote: An update is available and mostly changes only the test case, Bug8151626.java. The other change is to remove jtreg.security.policy.