AWT Dev java.awt.AWTKeyStroke.registerSubclass(Class? subclass) method usage.

2015-07-27 Thread Alexander Scherbatiy
Hello, The class KeyStroke has been added to the javax.swing package first and then copied to the java.awt.AWTKeyStroke. Most of KeyStroke class methods looks like registering KeyStroke class and call to the parent AWTKeyStroke method now. That is why the AWTKeyStroke.registerSubclass(Class?

AWT Dev [9] Review Request: 8132355 Incorrect guard block in HPkeysym.h, awt_Event.h

2015-07-27 Thread Sergey Bylokhov
Hello. Please review the fix for a typo in jdk9. The HPkeysym.h is from external library, so I have filed the bug in upstream too: https://bugs.freedesktop.org/show_bug.cgi?id=91469 Bug: https://bugs.openjdk.java.net/browse/JDK-8132355 Webrev can be found at:

Re: AWT Dev [9] Review Request: 8132355 Incorrect guard block in HPkeysym.h, awt_Event.h

2015-07-27 Thread Alexander Zvegintsev
Looks fine. Thanks, Alexander. On 07/27/2015 02:36 PM, Sergey Bylokhov wrote: Hello. Please review the fix for a typo in jdk9. The HPkeysym.h is from external library, so I have filed the bug in upstream too: https://bugs.freedesktop.org/show_bug.cgi?id=91469 Bug:

Re: AWT Dev [9] Review Request: 8132355 Incorrect guard block in HPkeysym.h, awt_Event.h

2015-07-27 Thread Anton V. Tarasov
+1 On 27.07.2015 15:16, Alexander Zvegintsev wrote: Looks fine. Thanks, Alexander. On 07/27/2015 02:36 PM, Sergey Bylokhov wrote: Hello. Please review the fix for a typo in jdk9. The HPkeysym.h is from external library, so I have filed the bug in upstream too:

Re: AWT Dev [9] Review request for 8014212: Robot captures black screen

2015-07-27 Thread Alexander Zvegintsev
Please see the updated version: http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/01/ robot makes shot of intersection of provided rectangle with root window. Old robot implementation works for negative x and y, but may return garbage outside of root window behavior, so it was updated too.

AWT Dev Accessing internal packages in JDK 9

2015-07-27 Thread Simon Nash
I have recently discovered that applications will no longer be able to access internal packages (sun.* and com.sun.*) in JDK 9. This is a major problem for my application as it requires access to some internal packages in order to work correctly. In most cases, my need to access these internal

Re: AWT Dev Accessing internal packages in JDK 9

2015-07-27 Thread Phil Race
The jdeps tool bundled with current JDK 8 updates should help you produced a definitive list - of your current uses. A web page about jpdeps and current recommended replacements for some internal APIs can be viewed at https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool

Re: AWT Dev Accessing internal packages in JDK 9

2015-07-27 Thread Simon Nash
Phil Race wrote: The jdeps tool bundled with current JDK 8 updates should help you produced a definitive list - of your current uses. Thanks for your quick reply. I will run this tool to check that my list is complete and correct. A web page about jpdeps and current recommended replacements

Re: AWT Dev Accessing internal packages in JDK 9

2015-07-27 Thread Phil Race
On 07/27/2015 03:56 PM, Simon Nash wrote: Phil Race wrote: The jdeps tool bundled with current JDK 8 updates should help you produced a definitive list - of your current uses. Thanks for your quick reply. I will run this tool to check that my list is complete and correct. A web page about

Re: AWT Dev Accessing internal packages in JDK 9

2015-07-27 Thread Phil Race
PS .. when you identify a workaround that you think bears a resemblance to the required fix, you could submit it as a patch. That way you won't lose track of the issues and it has a good chance of being fixed sooner. -phil. On 7/27/15 4:22 PM, Phil Race wrote: On 07/27/2015 03:56 PM, Simon

Re: AWT Dev Accessing internal packages in JDK 9

2015-07-27 Thread Michael Hall
On Jul 27, 2015, at 6:22 PM, Phil Race philip.r...@oracle.com mailto:philip.r...@oracle.com wrote: Will there be any way to access these if they are not public (for example, by reflection)? If this is possible, I should be able to adapt my current workaround code to run on JDK 9. My