Re: AWT Dev [9] Review Request: 4379403 Need to disable the magic AWT dump key (CTRL+SHIFT+F1)

2015-08-10 Thread Alexander Zvegintsev
Hello Sergey, the fix looks good to me. Thanks, Alexander. On 08/10/2015 02:35 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. After the fix a Magic dump key is disabled by default, to enable it the user needs to enable debug mode(via property file or system property).

Re: AWT Dev [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-10 Thread Yuri Nesterenko
Fine with me. -yan On 08/07/2015 01:56 PM, Renjith Alexander wrote: Hi all, Please review the fix for the bug: JDK-8132376: Add @requires os.family to the client tests with access to internal OS-specific API BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8132376* The webrev

AWT Dev [9] Review Request: 7124271 [macosx] RealSync test failure

2015-08-10 Thread Sergey Bylokhov
Hello. Please review the fix for jdk9. Two bugs were fixed: - The changes in NSApplicationAWT.waitForDummyEvent() is a fix for a regression of JDK-8080504, which does not take into account that we should not call an unlock if a lock operation was failed with timeout. - Initial bug which was

Re: AWT Dev [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-10 Thread Alexander Scherbatiy
On 8/7/2015 1:56 PM, Renjith Alexander wrote: Hi all, Please review the fix for the bug: JDK-8132376: Add @requires os.family to the client tests with access to internal OS-specific API BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8132376* The webrev