Re: AWT Dev [9] Review Request: 8067087 Fix mac-specific deprecation warnings in the java.desktop module

2015-08-17 Thread Sergey Bylokhov
Hello, Any volunteers to review the fix? On 10.08.15 14:51, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. Most of the warnings in the bug description were related to getPeer(), which was removed already. Other cases are fixed except the usage of

Re: AWT Dev [9] Review Request: 7124271 [macosx] RealSync test failure

2015-08-17 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/17/2015 3:17 PM, Sergey Bylokhov wrote: Hello, Any volunteers to review the fix? On 11.08.15 21:29, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. -- Thanks, Alexander. On 10.08.2015 14:21, Sergey Bylokhov wrote:

Re: AWT Dev [9] Review Request: 4379403 Need to disable the magic AWT dump key (CTRL+SHIFT+F1)

2015-08-17 Thread Sergey Bylokhov
Hello, Any volunteers to review the fix? On 10.08.15 15:56, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. Thanks, Alexander. On 08/10/2015 02:35 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. After the fix a Magic dump key is disabled by default, to

Re: AWT Dev [9] Review Request: 6778087 getLocationOnScreen() always returns (0, 0) for mouse wheel events

2015-08-17 Thread Sergey Bylokhov
Hello, Any volunteers to review the fix? On 12.08.15 17:23, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. Thanks, Alexander. On 08/10/2015 03:13 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. On Windows as well as OSX we do not fill the absolute

Re: AWT Dev [9] Review Request: 7124271 [macosx] RealSync test failure

2015-08-17 Thread Sergey Bylokhov
Hello, Any volunteers to review the fix? On 11.08.15 21:29, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. -- Thanks, Alexander. On 10.08.2015 14:21, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. Two bugs were fixed: - The changes in

Re: AWT Dev [9] Review Request: 4379403 Need to disable the magic AWT dump key (CTRL+SHIFT+F1)

2015-08-17 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/17/2015 3:18 PM, Sergey Bylokhov wrote: Hello, Any volunteers to review the fix? On 10.08.15 15:56, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. Thanks, Alexander. On 08/10/2015 02:35 PM, Sergey Bylokhov

Re: AWT Dev [9] Review Request: 8067087 Fix mac-specific deprecation warnings in the java.desktop module

2015-08-17 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/17/2015 3:20 PM, Sergey Bylokhov wrote: Hello, Any volunteers to review the fix? On 10.08.15 14:51, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. Most of the warnings in the bug description were related to getPeer(), which

Re: AWT Dev [9] Review request for 8131339[macosx] setMaximizedBounds() doesn't work for undecorated Frame

2015-08-17 Thread Sergey Bylokhov
The fix looks fine. On 30.07.15 14:08, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8131339/webrev.01/ It is not necessary to add default getMaximizedBounds() method to the PlatformWindow so I reverted this change. Thanks, Alexandr.