Re: AWT Dev Swing Dev JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
Hi Phil, On 8/20/2015 11:14 AM, Phil Race wrote: Joe, How is this keyword interpreted and used ? From the TEST.ROOT file in the jdk/test directory: # The randomness keyword marks tests using randomness with test # cases differing from run to run. (A test using a fixed random seed # would

Re: AWT Dev Swing Dev JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread Phil Race
Joe, How is this keyword interpreted and used ? How did you select the tests below to be so marked ? I might ask more once I understand the answers to these but looking at just one of these - MTGraphicsAccessTest.java - there is no such thing a spurious failure of this test. If you ever see a

Re: AWT Dev Swing Dev JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread Phil Race
So randomness is a keyword that is read by a human and interpreted in the process of filing a bug on the test ? The one I pointed out does not seem like it needs this treatment. If it fails there is nothing to argue about. A crash is pretty conclusive. So the others probably ought to be examined

AWT Dev JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
Hello, As part of implementing tiered testing [1], client library tests which use randomness should be marked with the corresponding keyword. The analogous changes have been made in core libs, see JDK-8078334: Mark regression tests using randomness. Webrev at JDK-8134084 : Mark client

Re: AWT Dev [awt-dev] Request for Approval and Review: JDK-8132376: [TEST_BUG] Add @requires os.family to the client tests with access to internal OS-specific API

2015-08-20 Thread Alexander Scherbatiy
On 8/18/2015 9:02 AM, Renjith Alexander wrote: Hi All, Please review the updated fix for Bug JDK-8132376: Webrev: http://cr.openjdk.java.net/~sgupta/8132376/webrev.03/ - Please, remove all Standard Test Machinery Section which is not really used in the test. The test only uses

AWT Dev [9] Request for review 8134028: [PIT] XToolkit, strange behavior of robot.createScreenCapture(): looks like a native crash in X11/GTK

2015-08-20 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8134028/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8134028 In previous robot fix I forgot to wrap gtk calls with gdk_threads_enter/gdk_threads_leave, therefore we have such failure. -- Thanks, Alexander.

Re: AWT Dev [9] Request for review 8134028: [PIT] XToolkit, strange behavior of robot.createScreenCapture(): looks like a native crash in X11/GTK

2015-08-20 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/20/2015 5:51 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8134028/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8134028 In previous robot fix I forgot to wrap gtk

Re: AWT Dev Swing Dev JDK 9 RFR of JDK-8134084: Mark client libs regression tests using randomness

2015-08-20 Thread joe darcy
On 8/20/2015 11:52 AM, Phil Race wrote: So randomness is a keyword that is read by a human and interpreted in the process of filing a bug on the test ? Yes, the randomness keyword is a message to the human reader of the test or someone doing analysis of a test failure. The connotation of the

AWT Dev [awt-dev] Request for Approval and Review: JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation

2015-08-20 Thread Renjith Alexander
Hi all, Please review the fix for the bug:  JDK-8133027: [Jigsaw] Test java/awt/PrintJob/Text/stringwidth.sh fails during compilation BUG ID - https://bugs.openjdk.java.net/browse/JDK-8133027   The webrev is: http://cr.openjdk.java.net/~pchopra/8133027/webrev.02/     One test(which are shown as