Looks fine.
Thanks,
Alexander.
On 08/25/2015 06:28 PM, Sergey Bylokhov wrote:
On 25.08.15 17:55, Alexander Zvegintsev wrote:
I think that there is no need in RuntimeException in mousePressed()
callback,
it could be replaced with println and break.
makes sense, the new version:
http://cr.ope
On 8/25/2015 6:28 PM, Sergey Bylokhov wrote:
On 25.08.15 17:55, Alexander Zvegintsev wrote:
I think that there is no need in RuntimeException in mousePressed()
callback,
it could be replaced with println and break.
makes sense, the new version:
http://cr.openjdk.java.net/~serb/8047226/webrev.0
The fix looks good to me.
Thanks,
Alexandr.
On 8/25/2015 3:56 PM, Renjith Alexander wrote:
Hi Alexander,
Formatted the code accordingly. Please find the diffs:
http://cr.openjdk.java.net/~pchopra/8132376/webrev.05/
http://cr.openjdk.java.net/~pchopra/8132376/webrev.06/
Regards,
Renjith.
--
The fix looks good to me.
Thanks,
Alexandr.
On 8/25/2015 7:47 PM, Alexander Stepanov wrote:
Sorry, just a reminder.
javax/swing/plaf/LayerUI.java was also touched.
Thanks,
Alexander
On 8/18/2015 2:51 PM, Alexander Stepanov wrote:
P.S. (sorry)
java.datatransfer/share/classes/java/awt
The fix looks good to me.
Thanks,
Alexandr.
On 8/4/2015 1:22 PM, Semyon Sadetsky wrote:
On 7/29/2015 2:06 PM, Alexander Scherbatiy wrote:
On 7/23/2015 9:21 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8130471
webrev: http://
On 26.08.2015 16:17, Alexander Scherbatiy wrote:
On 8/25/2015 6:28 PM, Sergey Bylokhov wrote:
On 25.08.15 17:55, Alexander Zvegintsev wrote:
I think that there is no need in RuntimeException in mousePressed()
callback,
it could be replaced with println and break.
makes sense, the new version:
Thanks!
On 8/26/2015 4:23 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 8/25/2015 7:47 PM, Alexander Stepanov wrote:
Sorry, just a reminder.
javax/swing/plaf/LayerUI.java was also touched.
Thanks,
Alexander
On 8/18/2015 2:51 PM, Alexander Stepanov w
Hi All,
I need +1 for this review. This is a simple fix. Can someone please review it.
Regards,
Renjith.
From: Renjith Alexander
Sent: Thursday, August 20, 2015 1:39 PM
To: awt-dev@openjdk.java.net
Subject: [awt-dev] Request for Approval and Review: JDK-8133027:
[Jigsaw] Test java/awt