Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-08-28 Thread Jim Graham
That looks good. I'm not sure what the standard practice is these days for using @code vs @link in comments. I think we used to have some sort of "first reference is @link, subsequent are @code" convention, but that may have changed, especially if you @see them as well and the 2 paragraphs ar

Re: [OpenJDK 2D-Dev] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2015-08-28 Thread Alexander Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.13 - The javadoc for MultiResolutionImage interface is updated. On 8/26/2015 1:45 AM, Phil Race wrote: On 08/25/2015 02:26 PM, Jim Graham wrote: Is MRI intended to be implemented only by classes that exten

Re: [9] Review Request: 8134603 Incorrect destination is used in CGLLayer surface

2015-08-28 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 08/28/2015 01:30 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 8/27/2015 4:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The CGLLayer.java has a typo it uses the peer as a destination, but the target sh

Re: [9] Review Request: 8134603 Incorrect destination is used in CGLLayer surface

2015-08-28 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 8/27/2015 4:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The CGLLayer.java has a typo it uses the peer as a destination, but the target should be used instead. This breaks the bufferPerWIndow functionality, because