+1
Thanks,
Alexander.
On 09/04/2015 05:43 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 9/3/2015 4:21 PM, Semyon Sadetsky wrote:
Alexanders? Any questions?
On 8/5/2015 3:11 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https:/
+1
On 04.09.15 18:39, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 9/3/2015 1:58 PM, Renjith Alexander wrote:
Hi all,
Please review the fix for the bug: JDK-8133539 - [TEST_BUG] Split
java/awt/image/MultiResolutionImageTest.java in two to allow
restr
The fix looks good to me.
Thanks,
Alexandr.
On 9/3/2015 1:58 PM, Renjith Alexander wrote:
Hi all,
Please review the fix for the bug: JDK-8133539 - [TEST_BUG] Split
java/awt/image/MultiResolutionImageTest.java in two to allow
restricted access
BUG ID - *https://bugs.openjdk.java.ne
The fix looks good to me.
Just format the code on line 79 before the push.
Thanks,
Alexandr.
On 9/3/2015 6:29 PM, Sergey Bylokhov wrote:
Looks fine.
On 03.09.15 17:57, Semyon Sadetsky wrote:
Guys, just a reminder.
On 8/4/2015 3:34 PM, Semyon Sadetsky wrote:
Hi Sergey,
It was not
The fix looks good to me.
Thanks,
Alexandr.
On 9/3/2015 4:21 PM, Semyon Sadetsky wrote:
Alexanders? Any questions?
On 8/5/2015 3:11 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8014725
webrev: http://cr.openjdk.java.net/~
Yes, I thought about that. But flip buffer is potentially allowed to
throw other exceptions caused by the platform.
Wouldn't it be excessive to introduce such unspecified expectation?
On 9/4/2015 5:01 PM, Sergey Bylokhov wrote:
On 04.09.15 15:12, Semyon Sadetsky wrote:
The original bug was abo
On 04.09.15 15:12, Semyon Sadetsky wrote:
The original bug was about ClastCastException.
Then probably catch AWTException which is only expected from
createBufferStrategy?. this will cover old and new bug.
With the option the test will check nothing if buffering is not
supported on the test
The original bug was about ClastCastException.
With the option the test will check nothing if buffering is not
supported on the test server.
On 9/4/2015 2:40 PM, Sergey Bylokhov wrote:
Hi, Semyon.
Is it really necessary to catch ClassCastException? Can you try to
test this functionality via -
Hi, Semyon.
Is it really necessary to catch ClassCastException? Can you try to test
this functionality via -Dswing.bufferPerWindow. When this option is
passed the backbuffer should be created automatically if supported.
On 04.09.15 14:03, Semyon Sadetsky wrote:
Hello,
Please review fix for J
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8134732
webrev: http://cr.openjdk.java.net/~ssadetsky/8134732/webrev.00/
It's a test bug: when the flip buffer is not available on the platform
its creation attempt causes exception.
Solution: ignore the exceptio
Hi Sergey,
I made the KeyboardFocusManager initialized lazy on the peer level.
Maybe you'll find it more acceptable.
http://cr.openjdk.java.net/~ssadetsky/8130895/webrev.01/
It is not possible to decouple KFM and the app context it belongs.
--Semyon
On 7/23/2015 7:38 AM, Semyon Sadetsky wrote
11 matches
Mail list logo
