Request for review fo bug JDK-8039467 [TEST_BUG] Test java/awt/Choice/UnfocusableToplevel/UnfocusableToplevel.java lefts keystrokes in a keyboard buffer on Windows

2015-09-09 Thread Ambarish Rapte
Hi, Please review the following fix for jdk9. Bug:https://bugs.openjdk.java.net/browse/JDK-8039467 Webrev: http://cr.openjdk.java.net/~psadhukhan/ambarish/8039467/webrev.00/ Issue: As the test window is non focusable, the automat

Re: [9] Review Request for 8134732: [TEST_BUG] Test java/awt/applet/Applet/AppletFlipBuffer.java fails on Windows with AWTException

2015-09-09 Thread Sergey Bylokhov
On 09.09.15 16:01, Semyon Sadetsky wrote: On 9/9/2015 3:29 PM, Sergey Bylokhov wrote: On 08.09.15 18:38, Semyon Sadetsky wrote: On 9/8/2015 2:11 PM, Sergey Bylokhov wrote: On 08.09.15 14:03, Semyon Sadetsky wrote: On 9/8/2015 1:37 PM, Sergey Bylokhov wrote: On 08.09.15 13:31, Semyon Sa

Re: [9, 8] Review request for 8081485: EDT auto shutdown is broken in case of new event queue usage

2015-09-09 Thread Sergey Bylokhov
On 09.09.15 16:09, Anton Litvinov wrote: Hello Sergey, Thank you for review of the second version of this fix and for this correction. Before sending this review request I ran this regression test on OS X, Windows, Linux, Solaris platforms. The test executed successfully and was not blocked, pro

Re: [9, 8] Review request for 8081485: EDT auto shutdown is broken in case of new event queue usage

2015-09-09 Thread Anton Litvinov
Hello Sergey, Thank you for review of the second version of this fix and for this correction. Before sending this review request I ran this regression test on OS X, Windows, Linux, Solaris platforms. The test executed successfully and was not blocked, probably because it does not use any JDK'

Re: [9] Review Request for 8134732: [TEST_BUG] Test java/awt/applet/Applet/AppletFlipBuffer.java fails on Windows with AWTException

2015-09-09 Thread Semyon Sadetsky
On 9/9/2015 3:29 PM, Sergey Bylokhov wrote: On 08.09.15 18:38, Semyon Sadetsky wrote: On 9/8/2015 2:11 PM, Sergey Bylokhov wrote: On 08.09.15 14:03, Semyon Sadetsky wrote: On 9/8/2015 1:37 PM, Sergey Bylokhov wrote: On 08.09.15 13:31, Semyon Sadetsky wrote: On 9/8/2015 12:38 PM, Serg

Re: [9] Review Request for 8134732: [TEST_BUG] Test java/awt/applet/Applet/AppletFlipBuffer.java fails on Windows with AWTException

2015-09-09 Thread Sergey Bylokhov
On 08.09.15 18:38, Semyon Sadetsky wrote: On 9/8/2015 2:11 PM, Sergey Bylokhov wrote: On 08.09.15 14:03, Semyon Sadetsky wrote: On 9/8/2015 1:37 PM, Sergey Bylokhov wrote: On 08.09.15 13:31, Semyon Sadetsky wrote: On 9/8/2015 12:38 PM, Sergey Bylokhov wrote: On 08.09.15 9:19, Semyon Sa

Re: [9, 8] Review request for 8081485: EDT auto shutdown is broken in case of new event queue usage

2015-09-09 Thread Sergey Bylokhov
Hi, Anton. The fix looks fine, but after the fix was approved the modules came to play. Please add correct @modules tag in the test before the push, because it uses internal api from sun.awt package. I guess it should be @modules java.desktop/sun.awt On 03.09.15 18:39, Anton Litvinov wrote: