Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

2015-09-11 Thread Renjith Alexander
Hi all, Please review the fix for the bug: JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java BUG ID - https://bugs.openjdk.java.net/browse/JDK-8132380 The webrev is: http://cr.openjdk.java.net/~pchopra/8132380/webrev.00/ -- Regards, Renjith

Re: Request for review fo bug JDK-8039467 [TEST_BUG] Test java/awt/Choice/UnfocusableToplevel/UnfocusableToplevel.java lefts keystrokes in a keyboard buffer on Windows

2015-09-11 Thread Ambarish Rapte
Many Thanks, Ambarish Rapte -Original Message- From: Sergey Bylokhov Sent: Thursday, September 10, 2015 11:55 PM To: Ambarish Rapte; Philip Race; awt-dev@openjdk.java.net Subject: Re: Request for review fo bug JDK-8039467 [TEST_BUG] Test

Re: < AWT- Dev> [9] Review Request:JDK-8136354 [TEST_BUG]Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script

2015-09-11 Thread Alexander Zvegintsev
looks fine Thanks, Alexander. On 09/11/2015 01:09 PM, pooja chopra wrote: Hello, Please review a fix for issue :- 8136354 [TEST_BUG]Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8136354 The webrev is :

Re: Request for review fo bug JDK-8039467 [TEST_BUG] Test java/awt/Choice/UnfocusableToplevel/UnfocusableToplevel.java lefts keystrokes in a keyboard buffer on Windows

2015-09-11 Thread Ambarish Rapte
Hi, Thanks for the review, Sergey. I require one more review for this patch, Can someone please review this. Webrev: http://cr.openjdk.java.net/~psadhukhan/ambarish/8039467/webrev.02/ Many Thanks, Ambarish Rapte -Original Message- From: Sergey Bylokhov Sent:

Re: < AWT- Dev> [9] Review Request:JDK-8136354 [TEST_BUG]Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script

2015-09-11 Thread Sergey Bylokhov
Looks fine. On 11.09.15 15:17, Alexander Zvegintsev wrote: looks fine Thanks, Alexander. On 09/11/2015 01:09 PM, pooja chopra wrote: Hello, Please review a fix for issue :- 8136354 [TEST_BUG]Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script Test bug fix.

Re: Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

2015-09-11 Thread Yuri Nesterenko
Looks OK to me. -yan On 09/11/2015 01:16 PM, Renjith Alexander wrote: Hi all, Please review the fix for the bug: JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java BUG ID -*https://bugs.openjdk.java.net/browse/JDK-8132380 * The webrev

Re: Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

2015-09-11 Thread Andrei Eremeev
Hi Renjith, Swing components should be created on the EDT to avoid concurrency problems. So rollback the 55, 56, 61 and 62 lines. Look at: https://docs.oracle.com/javase/tutorial/uiswing/concurrency/index.html Andrei On 11.09.2015 13:16, Renjith Alexander wrote: Hi all, Please review the

Re: Request for review fo bug JDK-8039467 [TEST_BUG] Test java/awt/Choice/UnfocusableToplevel/UnfocusableToplevel.java lefts keystrokes in a keyboard buffer on Windows

2015-09-11 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 9/11/2015 2:54 PM, Ambarish Rapte wrote: Hi, Thanks for the review, Sergey. I require one more review for this patch, Can someone please review this. Webrev: