Re: RFR: 8136570: Avoid setting environment variables related to /usr/dt

2015-09-15 Thread Martin Buchholz
We would be entirely happy if the environment frobbing code were to be deleted. Should I change my code to do that? On Tue, Sep 15, 2015 at 3:49 PM, Phil Race wrote: > I don't understand that original assessment. > Switching to XAWT had no impact on this code except to

Re: RFR: 8136570: Avoid setting environment variables related to /usr/dt

2015-09-15 Thread Phil Race
I don't understand that original assessment. Switching to XAWT had no impact on this code except to make it pointless. i.e it did not prevent its execution. I doubt there is any code left in the JDK that will derive any benefit from it still being there. All CDE/Motif & Xt related code is gone.

RFR: 8136570: Avoid setting environment variables related to /usr/dt

2015-09-15 Thread Martin Buchholz
I reported this bug 12 years ago, but it was closed Will Not Fix, and this year I see java programs crashing because of it! This is a partial fix. https://bugs.openjdk.java.net/browse/JDK-8136570 https://bugs.openjdk.java.net/browse/JDK-4953367

Re: Review request for JDK-8132380: Do not create LaF instance in javax/swing/plaf/windows/6921687/bug6921687.java

2015-09-15 Thread Renjith Alexander
Hi Andrei, Please see the updated version: http://cr.openjdk.java.net/~pchopra/8132380/webrev.01/ Regards, Renjith. From: Andrei Eremeev Sent: Friday, September 11, 2015 6:34 PM To: Renjith Alexander; awt-dev@openjdk.java.net Subject: Re: Review request for JDK-8132380: Do not

Re: RFR: JDK-8134808 Remove support for serialized applets from java.desktop

2015-09-15 Thread Sergey Bylokhov
Looks fine. 14.09.2015 22:12, Daniil Titov wrote: Hello, Please review java.desktop part of the changes for jdk9 that remove the support for serialized applets. Support for serialized applets was added in JDK 1.1 to allow an applet to be shipped in a pre-initialized state. Today, with modern

Re: RFR: JDK-8134808 Remove support for serialized applets from java.desktop

2015-09-15 Thread Daniil Titov
Thank you, Sergey and Alexander, for reviewing these changes! Best regards, Daniil -Original Message- From: Alexander Zvegintsev Sent: Tuesday, September 15, 2015 5:38 AM To: Sergey Bylokhov; Daniil Titov; Alexander Scherbatiy Cc: awt-dev@openjdk.java.net Subject: Re: RFR:

Re: RFR: JDK-8134808 Remove support for serialized applets from java.desktop

2015-09-15 Thread Alexander Zvegintsev
+1 -- Thanks, Alexander. On 15.09.2015 14:31, Sergey Bylokhov wrote: Looks fine. 14.09.2015 22:12, Daniil Titov wrote: Hello, Please review java.desktop part of the changes for jdk9 that remove the support for serialized applets. Support for serialized applets was added in JDK 1.1 to