Re: [9] Review Request for 8080395: consider making sun.awt.CausedFocusEvent functionality public

On 10/5/2015 6:47 PM, Sergey Bylokhov wrote: A few notes: - Typo in the header of the test: "Copyright (c) 20015", also please dispose the window before "throw new RuntimeException" - FocusEvent.java: some of the new javadoc overlap the 80 chars per line, also remove double spaces in the text

Re: [9] Review Request for 8022334: After calling frame.toBack() dialog goes to the back on Ubuntu 12.04

On 10/13/2015 6:03 PM, Sergey Bylokhov wrote: On 09/29/2015 08:51 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8022334 webrev: http://cr.openjdk.java.net/~ssadetsky/8022334/webrev.00/ The Unity WM cannot switch top-level windows

[9] RFR 8138838: docs cleanup for java.desktop

Sorry, just a reminder. If the activity is untimely, then could you please review the following minimum part of fix? http://cr.openjdk.java.net/~avstepan/8138838/webrev.min.00/index.html (some misprints + midget JDK-8138893 fixed). Thanks, Alexander On 10/5/2015 2:12 PM, Alexander Stepanov wro

Review Request for 8055197: TextField deletes multiline strings

Dear All, Please review the patch for jdk9. Bug: https://bugs.openjdk.java.net/browse/JDK-8055197 Webrev: http://cr.openjdk.java.net/~rchamyal/ambarish/8055197/webrev.00/ Issue: - If text containing new line character is set to TextField, Text after new line character was termin

Re: [9] Review request for 8130136: Swing window sometimes fails to repaint partially when it becomes exposed

Hello Alex, On 14.10.2015 17:11, Alexander Potochkin wrote: Hello Alexey When does the GetHWnd() method return zero? Do we need to check it in RemoveDC? GetHWnd() cannot return NULL in WndProc. No NULL-check is necessary. As far as I can see AwtComponent::GetHWnd can return zero. Well, it

Re: [9] Review request for 8130136: Swing window sometimes fails to repaint partially when it becomes exposed

Hello Alexey When does the GetHWnd() method return zero? Do we need to check it in RemoveDC? GetHWnd() cannot return NULL in WndProc. No NULL-check is necessary. As far as I can see AwtComponent::GetHWnd can return zero. Well, it could... but if it had done so, something bad would already

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

Hi Semyon, As I can see there are a lot similar checks in tests for OEL7, ideally it should be checked against gnome-shell(probably from DESKTOP_SESSION env variable, or check for running gnome-shell process), but I am OK with the current check. Could you please extract this check to some he

Re: [9] Review request for 8136999[macosx] NSException and NPE in a crash test

Hi Alexander, The fix looks good. --Semyon On 10/7/2015 4:25 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8136999 webrev: http://cr.openjdk.java.net/~alexsch/8136999/webrev.00 The test sets drop target to null in the dr

Re: [9] Review request for 8130136: Swing window sometimes fails to repaint partially when it becomes exposed

Hello Alex, On 13.10.2015 19:54, Alexander Potochkin wrote: Hello Alexey Hello Alex, Thank you for your review. Here's the updated webrev: http://cr.openjdk.java.net/~aivanov/8130136/jdk9/webrev.01/ Please see my comments inline. On 12.10.2015 20:25, Alexander Potochkin wrote: Hello Ale

Re: [9] Review Request for 8074810: [TESTBUG] Please evaluate and perhaps fix some rather complex regression tests using internal API

Hi Yuri, On 10/9/2015 8:51 AM, Semyon Sadetsky wrote: As I understood the purpose of this bug (it's really unclear), is to eliminate dependency on AWTAccessor since this class will be removed soon. Not 100% sure that it has any connection to the jake. You may ask the author of the bug what