design question regarding UI defaults and painting

2015-11-12 Thread Alan Snyder
I am curious about a design decision that was made in the implementation of textured window backgrounds in the Aqua LAF/AWT. In a nutshell, a textured window background is an optional NSWindow background style that involves gradients. Textured windows are requested in Java using a window client

Re: JDK9 Review Request for 8037575: JFrame on Windows doesn't animate when setting ICONIFIED state

2015-11-12 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 10/13/2015 11:12 AM, Rajeev Chamyal wrote: Hello All, Please review the following webrev. Bug: https://bugs.openjdk.java.net/browse/JDK-8037575 Webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8037575/webrev.00/

Re: [OpenJDK 2D-Dev] [rfc]Stream doesn't reset mark in finally

2015-11-12 Thread Sergey Bylokhov
Hi, Jiri. This is a valid point, did you file a new CR for this issue? On 09.11.15 15:45, Alexander Scherbatiy wrote: On 11/7/2015 11:38 AM, Jiri Vanek wrote: Hello! Looking to imageIO.java (if this is bad thread, please redirect me!) 2d-dev alias should be also the right place to ask i

Re: [OpenJDK 2D-Dev] [9] Review request for 8137571 Linux HiDPI Graphics support

2015-11-12 Thread Sergey Bylokhov
This version looks fine. A few notes which we discussed offline: - It will be good to understand how SG2D.copyarea should work in case of transformed graphics. - The different types of embedding should be checked(plugin,swt,fx). - I suggest to run some benchmarks to figure out what performance

Review Request for 8142861: [TEST_BUG] MultiResolution image: add a manual test for two-display configuration (HiDPI + non-HiDPI)

2015-11-12 Thread Alexander Stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~anazarov/8142861-3/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8142861 Just a single manual test added. (sorry, I'll remove these unnecessary 'static' modifiers for 'parentName', 'childName') Checked on M

[9] Review request for: 8020817: JDK-8086038 requires a regression test

2015-11-12 Thread mikhail cherkasov
Hello, Please please review a regression test for 8086038, it checks that PICT format support is present. bug: https://bugs.openjdk.java.net/browse/JDK-8020817 webrev: http://cr.openjdk.java.net/~mcherkas/8086038/webrev/ Thanks, Mikhail.