Re: Review-request for 8048731: JEP 272: Platform-Specific Desktop Features

> On Nov 19, 2015, at 9:27 AM, Alexander Zvegintsev > wrote: > > It is only on the AWT side currently. > There is no such documentation yet, however you can see the mapping at [0] > and [1]. > > [0] > http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/src/java.desktop/macosx/classes/sun/lw

Re: Review-request for 8048731: JEP 272: Platform-Specific Desktop Features

> On Nov 19, 2015, at 3:40 PM, Anthony Vanelverdinghe > wrote: > > Hi Alexander > > One thing I strongly feel should be revisited, is the FileManager API. fwiw, https://github.com/mik3hall/trz is a project of mine mostly related to platform specific, OS X, n

Re: Review-request for 8048731: JEP 272: Platform-Specific Desktop Features

Hi Alexander One thing I strongly feel should be revisited, is the FileManager API. Here's my view on this: - the functionality for the HFS/HFS+ attributes should be provided by interfaces in java.nio.file.attribute, analog to dos/posix file attributes - the getResource/getPathToApplicationBund

Re: Review request for 8060137: Removing Text from TextField / TextArea is not possible after typing

Hi Semyon,       Please review the updated patch as per the review comments, http://cr.openjdk.java.net/~arapte/8060137/webrev.01/     Many Thanks Ambarish   From: Semyon Sadetsky Sent: Thursday, November 19, 2015 2:54 PM To: Ambarish Rapte; Prasanta Sadhukhan; awt-dev@openjdk

Re: Review-request for 8143227: Platform-Specific Desktop Features

Hi Alexander, I tried it with Ubuntu 14.04.3, and it started indeed from dash or a command line as a gray rectangle. Once I added isSupported() for every Action and separately for the Taskbar, it reported, just like jdk9b91, that only OPEN was supported and nothing else. Is it OK? dconf editor i

Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8019280 Webrev: http://cr.openjdk.java.net/~rchamyal/avik/8019280/webrev.00/ Issue: The Open

Re: Review-request for 8048731: JEP 272: Platform-Specific Desktop Features

It is only on the AWT side currently. There is no such documentation yet, however you can see the mapping at [0] and [1]. [0] http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/src/java.desktop/macosx/classes/sun/lwawt/macosx/CDesktopPeer.java.udiff.html [1] http://cr.openjdk.java.net/~azv

Re: Review-request for 8143227: Platform-Specific Desktop Features

Hi Yuri, Nice catch! Just tested on Ubuntu 14.04.3, it does not have libunity.so symlink to libuity.so.9. so we should try to load version 9 instead of 0 in awt_Taskbar.c: -#define UNITY_LIB_VERSIONED VERSIONED_JNI_LIB_NAME("unity", "0") +#define UNITY_LIB_VERSIONED VERSIONED_JNI_LIB_NAME("unit

Re: [9] Review request for: 8020817: JDK-8086038 requires a regression test

Hi, Mikhail. The test looks fine, but it required a @module tag because it uses private sun.awt.datatransfer package. On 12.11.15 18:27, mikhail cherkasov wrote: Hello, Please please review a regression test for 8086038, it checks that PICT format support is present. bug: https://bugs.openj

Re: Review request for 8060137: Removing Text from TextField / TextArea is not possible after typing

Looks ok to me. Regards Prasanta On 11/16/2015 3:54 PM, Ambarish Rapte wrote: Dear All, Please review the fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8060137 Webrev: http://cr.openjdk.java.net/~arapte/8060137/webrev.00/

Re: Review request for 8060137: Removing Text from TextField / TextArea is not possible after typing

Hi Prasanta, Could you rework the fix a bit? When peer != null is false there is no need to continue the method execution. And then second peer is null test is not needed. --Semyon On 11/16/2015 1:24 PM, Ambarish Rapte wrote: Dear All, Please review the fix for JDK9,

Re: Review Request for 8055197: TextField deletes multiline strings

Dear Alex, Please take a look at updated webrev, http://cr.openjdk.java.net/~rchamyal/ambarish/8055197/webrev.03/ Updated the test code for testing de-serialization. Many Thanks Ambarish -Original Message- From: Alexander Scherbatiy Sent: Friday, November 06,