Re: Review request for 8132766: [TESTBUG] Fix JDK-8068228 failed for java/awt/Mouse/MaximizedFrameTest/MaximizedFrameTest in MacOSX

Hi Manajit, Why do you use Logger for output? Potentially Logger can be configured to redirect or hide output. Are you sure that it will be jprt compatible? I afraid that jprt team expects that System.out/err are only used in tests, so we may miss the Logger output in the test report. --Semy

Re: Review Request for 8055197: TextField deletes multiline strings

Hi, Gentle reminder, please review. Many Thanks, Ambarish -Original Message- From: Ambarish Rapte Sent: Friday, November 20, 2015 3:49 PM To: Alexander Scherbatiy Cc: Prasanta Sadhukhan; Semyon Sadetsky; awt-dev@openjdk.java.net Subject: RE: Review Request for 8055197: TextField

Re: Review request for 8132766: [TESTBUG] Fix JDK-8068228 failed for java/awt/Mouse/MaximizedFrameTest/MaximizedFrameTest in MacOSX

Hi,     This fix looks good to me.   Many Thanks, Ambarish   From: Manajit Halder Sent: Monday, November 23, 2015 5:08 PM To: Ambarish Rapte; Semyon Sadetsky; awt-dev@openjdk.java.net Subject: Review request for 8132766: [TESTBUG] Fix JDK-8068228 failed for java/awt/Mouse/Maximi

Re: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

Hi All, Please find below the web rev with inputs from comments. http://cr.openjdk.java.net/~aniyogi/8019280/webrev.02/ With Regards, Avik Niyogi > On 24-Nov-2015, at 5:16 pm, Avik Niyogi wrote: > > Hi Semyon, > > I checked the rest of

Re: Review-request for 8143227: Platform-Specific Desktop Features

Please review the updated fix: http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/03/ removed fullscreen related code (moved to JDK-8143914 [0]) fix serialization in AppEvent [0] https://bugs.openjdk.java.net/browse/JDK-8143914 Thanks, Alexander. On 11/21/2015 03:33 AM, Alexander Zvegintsev w

Re: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

Hi Semyon, I checked the rest of the JDK and found out that there is no localisation bundle so there is no need for NSLocalizedString. I will change that and create new webrev. Trailing white space is used because the button size is not sufficient. With Regards, Avik Niyogi > On 24-Nov-2015, at

Re: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

Hi Avik, Did you try to change the locale? Did button get the localized text then? Why do you use trailing white-spaces for the key? The second argument of NSLocalizedString should be a comment. Perhaps, it'd be better to write a key description there instead of repeating the key. --Semyon O

Re: [9] Review Request for 8067470: Examine if the replacement for sun.awt.SunToolkit.setLWRequestStatus should be provided

On 10/5/2015 3:11 PM, Sergey Bylokhov wrote: On 05.10.15 15:03, Semyon Sadetsky wrote: Sergey, any other thoughts? I suggest to postpone the fix as discussed in private(latest massage was added to the CR). Sergey. I have answered you in CR. I disagree with your comment. This fix is not ris

Re: [OpenJDK 2D-Dev] [rfc]Stream doesn't reset mark in finally

On 11/18/2015 06:17 PM, Jiri Vanek wrote: On 11/12/2015 02:24 PM, Sergey Bylokhov wrote: Hi, Jiri. This is a valid point, did you file a new CR for this issue? ping? Hello! here it is: https://jvanek.fedorapeople.org/oracle/jdk8/webrevs/resetInTryFinally/v1/ Patch: https://jvanek.fedora

Re: Review request for 8019280: CFileDialog selection button on choose directory mode should read " Choose "

Hi Avik, This fix patch Looks good to me. Thanks Ambarish From: Avik Niyogi Sent: Monday, November 23, 2015 5:50 PM To: Ambarish Rapte Cc: Semyon Sadetsky; awt-dev@openjdk.java.net Subject: Re: Review request for 8019280: CFileDialog selection button on choose directory