Re: Review request for 8041928: MouseEvent.getModifiersEx gives wrong result

Fix looks good to me. Regards, Rajeev Chamyal -Original Message- From: Ambarish Rapte Sent: 23 December 2015 01:32 To: Ambarish Rapte; Rajeev Chamyal; Sergey Bylokhov; Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net Subject: RE: Review request for 8041928: MouseEvent.getM

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

Thanks for the reply Anton and thanks for the fix you are working on. It will be good to get at least one other set of eyes on the changes as I am not very familiar with that code (but am starting to because I'm looking into fixing some accessibility issues raised by the Andriod Studio team). -Pe

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

Hi Pete, Thanks for the review! > On 22 Dec 2015, at 23:07, Pete Brunet wrote: > > Hi Anton, Some comments/questions: > - Some copyright dates need updating Indeed, I’ll update them. > - Line 1112 of JavaComponentAccessibility: does the release of jaccessible > cause a release of jparent? A

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

Hi Anton, Some comments/questions: - Some copyright dates need updating - Line 1112 of JavaComponentAccessibility: does the release of jaccessible cause a release of jparent? - Line 7155 of Component.java: is that the only place where this means is needed? Pete On 12/22/15 8:10 AM, Anton Tarasov

Re: Review request for 8041928: MouseEvent.getModifiersEx gives wrong result

Hi Rajeev, Thanks for the review, Please review the updated patch with required changes in test file at, http://cr.openjdk.java.net/~arapte/8041928/webrev.02/ Regards, Ambarish -Original Message- From: Ambarish Rapte Sent: Tuesday, December 22, 2015 8:10 PM To

Re: [9] Review Request for 8145795: [TEST_BUG][PIT] java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can assign Integer.MAX_VALUE to Window dimensions)

Right. This is regression of 8073320. Fix is annulled. Thanks. --Semyon On 12/22/2015 6:03 PM, Yuri Nesterenko wrote: Semyon, but earlier builds of jdk9 could handle this bordercase properly, didn't they?. E.g. b95? -yan On 12/22/2015 04:22 PM, Semyon Sadetsky wrote: Hello, Please review f

Re: [9] Review Request for 8145795: [TEST_BUG][PIT] java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can assign Integer.MAX_VALUE to Window dimensions)

Semyon, but earlier builds of jdk9 could handle this bordercase properly, didn't they?. E.g. b95? -yan On 12/22/2015 04:22 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8145795 webrev: http://cr.openjdk.java.net/~ssadetsky/8145795

Re: Review request for 8041928: MouseEvent.getModifiersEx gives wrong result

Hi Rajeev, Thanks for the review, Please review the updated test at, http://cr.openjdk.java.net/~arapte/8041928/webrev.01/ Regards, Ambarish -Original Message- From: Rajeev Chamyal Sent: Tuesday, December 22, 2015 3:36 PM To: Ambarish Rapte; Sergey Bylokhov; Sem

[9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

Hi guys! Could you please review the problem I’ve filed and the suggested fix? bug: JDK-8145984 sun.lwawt.macosx.CAccessible leaks webrev: http://cr.openjdk.java.net/~ant/JDK-8145984/jdk9/webrev.0 (This is to be addressed in 8u/9. The webrev fo

[9] Review Request for 8145795: [TEST_BUG][PIT] java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can assign Integer.MAX_VALUE to Window dimensions)

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8145795 webrev: http://cr.openjdk.java.net/~ssadetsky/8145795/webrev.00/ Windows do not accept Integer.MAX_VALUE as dimension for internal reasons. Twice less value works. --Semyon

[9] Review Request for 8139218: Dialog that opens and closes quickly changes focus in original focusowner

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8139218 webrev: http://cr.openjdk.java.net/~ssadetsky/8139218/webrev.00/ The root cause: when window gain focus come for window that is hidden already focus rollback to another window cannot be done synchronously.

Re: Review request for 8041928: MouseEvent.getModifiersEx gives wrong result

Hello Ambarish, The test instruction window is not getting closed after the test timeout on pressing close button/Ctrl-C. Regards, Rajeev Chamyal -Original Message- From: Ambarish Rapte Sent: 22 December 2015 14:08 To: Sergey Bylokhov; Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@open

Re: Review request for 8041928: MouseEvent.getModifiersEx gives wrong result

Hi, Can I get one more review for this patch please. Thanks, Ambarish -Original Message- From: Ambarish Rapte Sent: Monday, December 21, 2015 11:27 AM To: Sergey Bylokhov; Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net Subject: RE: Review request for 8041928: Mou