Re: Review-request for 8143227: Platform-Specific Desktop Features

2016-02-02 Thread Semyon Sadetsky
Hi Alexander, Thank you for the update. It works for me. One additional remark. You do not call ::CoUninitialize() in awt_Taskbar.cpp. And I'm not sure that COM init/uninit can be done from arbitrary thread without aftereffects. MSDN states the next: A thread must call CoUninitialize once fo

Re: [9] Review Request for 8080395: consider making sun.awt.CausedFocusEvent functionality public

2016-02-02 Thread Semyon Sadetsky
Please review the updated webrev: http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.04/ - CausedFocusEvent is restored to avoid CNFE during deserialization. - readResolve() is added to FocusEvent to handle the null cause test. - deserialization compatibility test scenarios added --Semyon

Re: Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

2016-02-02 Thread Prem Balakrishnan
Hi Ambarish, Updated test . Webrev: http://cr.openjdk.java.net/~arapte/prem/8062946/webrev.01/ Regards, Prem From: Ambarish Rapte Sent: Tuesday, February 02, 2016 2:47 PM To: Alexander Scherbatiy; Prem Balakrishnan; Semyon Sadetsky; Sergey Bylokhov; Rajeev Chamyal; swing-...@openj

Re: Review request for 8005918 : [TESTBUG] There are no 'Frame Enter' messages for both frames, only 'Button Enter' message.

2016-02-02 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 2/2/2016 1:00 AM, Ambarish Rapte wrote: Hi Ajit, Fix looks good to me. Thanks, Ambarish *From:*Ajit Ghaisas *Sent:* Monday, February 01, 2016 4:47 PM *To:* Ambarish Rapte; Sergey Bylokhov; Semyon Sadetsky; awt-dev@openjdk.java.net *Subject:*

Re: [9] Review request for 8139581: AWT components are not drawn after removal and addition to a container

2016-02-02 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 2/2/2016 12:15 AM, Semyon Sadetsky wrote: Hello Anton, Thanks for the explanation. The fix looks good to me. --Semyon On 2/1/2016 6:29 PM, Anton Litvinov wrote: Hello Semyon, Thank you for review of this fix. This issue depends on race condit

Re: Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

2016-02-02 Thread Ambarish Rapte
Hi Prem, The test passes without including the fix. The test should fail without fix, and should pass with fix. Thanks, Ambarish From: Alexandr Scherbatiy Sent: Monday, February 01, 2016 5:15 PM To: Prem Balakrishnan; Semyon Sadetsky; Sergey Bylokhov; Amb

Re: Review request for 8005918 : [TESTBUG] There are no 'Frame Enter' messages for both frames, only 'Button Enter' message.

2016-02-02 Thread Ambarish Rapte
Hi Ajit, Fix looks good to me. Thanks, Ambarish From: Ajit Ghaisas Sent: Monday, February 01, 2016 4:47 PM To: Ambarish Rapte; Sergey Bylokhov; Semyon Sadetsky; awt-dev@openjdk.java.net Subject: RE: Review request for 8005918 : [TESTBUG] There are no 'Fra

Re: [9] Review request for 8139581: AWT components are not drawn after removal and addition to a container

2016-02-02 Thread Semyon Sadetsky
Hello Anton, Thanks for the explanation. The fix looks good to me. --Semyon On 2/1/2016 6:29 PM, Anton Litvinov wrote: Hello Semyon, Thank you for review of this fix. This issue depends on race conditions. In fact this issue is reproducible sometimes also, when the components are initially