Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

2016-02-26 Thread Sergey Bylokhov
Just one additional note: When you created a MRI you set a nok image as a base image, which means that the size of the MRI will consider wrong(small). And this contradicts the description of the test: "Please check if both of them have correct size", because setImageAutoSize is false by default.

Re: [9] Review Request for 8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios

2016-02-26 Thread Alexander Zvegintsev
+1 -- Thanks, Alexander. On 10.02.2016 14:06, Sergey Bylokhov wrote: Looks fine. On 01.10.15 21:27, Semyon Sadetsky wrote: The fix is amended : plese review the new version http://cr.openjdk.java.net/~ssadetsky/8021961/webrev.01/ It is taken into account that the transientFor chain may be lon

Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

2016-02-26 Thread Alexander Stepanov
Thanks! (will remove "for a few seconds"). Regards, Alexander On 2/26/2016 6:25 PM, Sergey Bylokhov wrote: Looks fine. Note that the text "Two tray icons will appear for a few seconds " should be updated also. On 26.02.16 18:04, Alexander Stepanov wrote: > Is it possible to clear the tray wh

Re: [9] Review reuest for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

2016-02-26 Thread Alexander Zvegintsev
Hi Sergey, Yes, it is, anyway I can see only a part of the fix in this webrev. -- Thanks, Alexander. On 26.02.2016 16:57, Sergey Bylokhov wrote: Hi, Alexander. It seems that this request is withdrawn? On 24.11.14 18:07, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.ope

Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

2016-02-26 Thread Sergey Bylokhov
Looks fine. Note that the text "Two tray icons will appear for a few seconds " should be updated also. On 26.02.16 18:04, Alexander Stepanov wrote: > Is it possible to clear the tray when the test ended? Yes, we can use the Applet's stop() method, please see http://cr.openjdk.java.net/~avstepa

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Alexander Stepanov
It seemingly does not help (but maybe I'm doing something wrong). On 2/26/2016 5:45 PM, Sergey Bylokhov wrote: On 26.02.16 17:27, Alexander Stepanov wrote: It seems that for osx + retina 1. -Dsun.java2d.uiScale option is ignored for multires. image (in contrast for HiDPI + Win. 8, for example)

Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

2016-02-26 Thread Alexander Stepanov
> Is it possible to clear the tray when the test ended? Yes, we can use the Applet's stop() method, please see http://cr.openjdk.java.net/~avstepan/8150643/webrev.01/ Thanks, Alexander On 2/26/2016 4:47 PM, Sergey Bylokhov wrote: I think it is not a good idea to block the EDT, or to expect that

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Sergey Bylokhov
On 26.02.16 17:27, Alexander Stepanov wrote: It seems that for osx + retina 1. -Dsun.java2d.uiScale option is ignored for multires. image (in contrast for HiDPI + Win. 8, for example). Should it be considered as a bug? At a 1st glance, yes. 2. even in case of correct color robot's getPixelColor(

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Alexander Stepanov
It seems that for osx + retina 1. -Dsun.java2d.uiScale option is ignored for multires. image (in contrast for HiDPI + Win. 8, for example). Should it be considered as a bug? At a 1st glance, yes. 2. even in case of correct color robot's getPixelColor() returns for retina a bit shifted color ((

Re: [9] Review reuest for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

2016-02-26 Thread Sergey Bylokhov
Hi, Alexander. It seems that this request is withdrawn? On 24.11.14 18:07, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8036915/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8036915 The sample in JBS issue reusing one window w

Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

2016-02-26 Thread Sergey Bylokhov
I think it is not a good idea to block the EDT, or to expect that the user will be able to find icon in a 7 seconds, especially if he run the test for the firts time. Is it possible to clear the tray when the test ended? On 26.02.16 16:39, Alexander Stepanov wrote: Hello Sergey, This is a ti

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Alexander Stepanov
Hello Sergey, No, as well as for 8150724. I have to re-check, thank you. Regards, Alexander On 2/26/2016 4:36 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on my OSX 10.11 + retina. Is it expected? On 25.02.16 17:51, Alexander Stepanov wrote: Sorry, just a reminder. Thanks, Alex

Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

2016-02-26 Thread Alexander Stepanov
Hello Sergey, This is a time interval for the user to examine the icons (which could, e.g., go to the tray pool). So my feeling is that it is a more or less suitable interval, but it could be shortened for a couple of seconds, of course. Thanks, Alexander On 2/26/2016 4:31 PM, Sergey Bylokh

Re: [8] RFR for 8150258: [TEST] HiDPI: create a test for multiresolution menu items icons

2016-02-26 Thread Sergey Bylokhov
Hi, Alexander. The test failed on my OSX 10.11 + retina. Is it expected? On 25.02.16 17:51, Alexander Stepanov wrote: Sorry, just a reminder. Thanks, Alexander On 2/19/2016 7:17 PM, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepa

Re: [9] RFR for 8150643: [TEST] add test for JDK-8150176

2016-02-26 Thread Sergey Bylokhov
Is it really necessary to block the EDT for 7 seconds? On 25.02.16 18:22, Alexander Stepanov wrote: (sorry, misprint, [9], not [8]. the same for RFR 8150258) On 2/25/2016 5:50 PM, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

2016-02-26 Thread Sergey Bylokhov
Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test

Re: Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

2016-02-26 Thread Sergey Bylokhov
Looks fine. On 26.02.16 15:53, Vikrant Agarwal wrote: Hi Sergey, I have updated the test to a standalone test. Updated Webrev: http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.02/ Bug: JDK-6734341 : REGTEST fails: SelectionAutoscrollTest.html Best Regards, Vikrant -Original Messag

[9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

2016-02-26 Thread Alexander Stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander

Re: Review request for 6734341 : REGTEST fails: SelectionAutoscrollTest.html

2016-02-26 Thread Vikrant Agarwal
Hi Sergey, I have updated the test to a standalone test. Updated Webrev: http://cr.openjdk.java.net/~ntv/vikrant/6734341/webrev.02/ Bug: JDK-6734341 : REGTEST fails: SelectionAutoscrollTest.html Best Regards, Vikrant -Original Message- From: Sergey Bylokhov Sent: Thursday, February 25