Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

2016-03-13 Thread Semyon Sadetsky
Hi Manajit, The fix itself looks good. Several minor remarks: - In the test setting GridBagLayout to the frame seems meaningless. - The year in the files header should be 2016. - For the future, add " [9]" in the beginning of review subject. --Semyon On 3/9/2016 4:43 PM, Manajit Halder wrote:

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

2016-03-13 Thread Rajeev Chamyal
Hello Sergey, Could you please review the enhancement. I have raised a new enhancement for unifying the splash screen image names across platforms. https://bugs.openjdk.java.net/browse/JDK-8151787 Regards, Rajeev Chamyal From: Alexandr Scherbatiy Sent: 10 March 2016 18:46 To: Rajee

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

2016-03-13 Thread Avik Niyogi
Hi Manajit, The fix looks good to me. With Regards, Avik Niyogi > On 09-Mar-2016, at 7:13 pm, Manajit Halder wrote: > > Hi All, > > Please review webrev.01 updated with Avik’s review comments. > > http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.01/ >