[9] Review Request: 8151773 [macosx] TrayIcon.imageAutoSize property is ignored

Hello, Please review the small fix for jdk9. According to specification if imageAutoSize property was set to true the image should be the stretched or shrunk to fit the tray icon space. But on OSX this flag is ignored in the native code. In the fix this flag is taken into account, if it was s

Re: RFR: JDK-8151770: 9-client windows builds failed from 2016-03-11

Hi Erik, Looks OK and I verified your jprt job completed. I have pushed it as -u erikj Separately I am trying to find out why there was no email notification the nightly builds were failing. -phil. On 3/14/16, 9:56 AM, Erik Joelsson wrote: Hello, The build is currently broken on Windows in j

RFR: JDK-8151770: 9-client windows builds failed from 2016-03-11

Hello, The build is currently broken on Windows in jdk9/client. This patch reverts some and cleans up the makefile changes made in JDK-8145174. I have verified that it builds on Windows and Linux and am just starting a JPRT job to verify the rest. Looking through the review thread for JDK-81

Re: [9] RFR for 8151714: [TEST] add a manual test test for JOptionPane dialog multires. icons

Hello Semyon, > JOptionPane.showInternalInputDialog() is an utility method Yes, the initial intention was to check the icons for all the dialogs created by means of these utilities. But in principle these options could be skipped, and the test could be limited by checking the icons for JOption

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

It would be good to check the build via jprt also. On 14.03.16 14:57, Alexander Scherbatiy wrote: On 3/14/2016 8:03 AM, Rajeev Chamyal wrote: Hello Sergey, Could you please review the enhancement. I have raised a new enhancement for unifying the splash screen image names across platforms. h

Re: Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi, Manajit. Why the test is OSX specific? It seems this functionality should be cross platform? It would be good to have a small delay between keypress/release(or autodelay in robot). On 09.03.16 16:43, Manajit Halder wrote: Hi All, Please review webrev.01 updated with Avik’s review comment

Re: [9] Review request for JDK-8145173 HiDPI splash screen support on Windows

On 3/14/2016 8:03 AM, Rajeev Chamyal wrote: Hello Sergey, Could you please review the enhancement. I have raised a new enhancement for unifying the splash screen image names across platforms. https://bugs.openjdk.java.net/browse/JDK-8151787 575 float *scaleFactor) 576 { 577 *scale

Re: [9] Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

+1 On 3/14/2016 12:10 PM, Avik Niyogi wrote: Hi Manajit, The fix looks good to me. With Regards, Avik Niyogi On 14-Mar-2016, at 2:42 pm, Manajit Halder > wrote: Hi Semyon & Avik, Thanks to both of you for the review. Please review the modified the code. htt

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

Thanks! On 3/14/2016 12:12 PM, Yuri Nesterenko wrote: +1 -yan On 03/11/2016 06:05 PM, Alexander Scherbatiy wrote: The test looks good to me. Thanks, Alexandr. On 11/03/16 16:19, Alexander Stepanov wrote: Hello Alexandr, Thank you for the explanation. Could you please review the updated t

Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons

+1 -yan On 03/11/2016 06:05 PM, Alexander Scherbatiy wrote: The test looks good to me. Thanks, Alexandr. On 11/03/16 16:19, Alexander Stepanov wrote: Hello Alexandr, Thank you for the explanation. Could you please review the updated test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.

Re: [9] Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Manajit, The fix looks good to me. With Regards, Avik Niyogi > On 14-Mar-2016, at 2:42 pm, Manajit Halder wrote: > > Hi Semyon & Avik, > > Thanks to both of you for the review. > > Please review the modified the code. > http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.02/ >

[9] Review request for JDK-8149456: [macosx] robot.keyPress do not generate key events (keyPressed and keyReleased) for function keys F13 to F19.

Hi Semyon & Avik, Thanks to both of you for the review. Please review the modified the code. http://cr.openjdk.java.net/~arapte/manajit/8149456/webrev.02/ Regards, Manajit > On 14-Mar-2016, at 11:38 am, Semyon Sadetsky > wrot