On 4/4/2016 9:47 PM, Philip Race wrote:
+1 (assuming only the one change, since I didn't re-review in entirety.).
Also assuming the answer to this :
> 39 private static final long serialVersionUID =
-3647309088427840738L;
> Is this the value generated by JDK 8 ? It should be ..
was "ye
+1 (assuming only the one change, since I didn't re-review in entirety.).
Also assuming the answer to this :
> 39 private static final long serialVersionUID =
-3647309088427840738L;
> Is this the value generated by JDK 8 ? It should be ..
was "yes".
-phil.
On 4/4/16, 1:21 AM, Alexande
Please take a look at the slightly changed version
of this test-only fix.
Semyon, thank you! I'm sorry I have to update it:
now we have new syntax for addExport; the old syntax
will eventually stop working.
yan
On 03/31/2016 04:24 PM, Yuri Nesterenko wrote:
Hi,
could you please review this te
Webrev: http://cr.openjdk.java.net/~yan/8152693/webrev.01
On 04/04/2016 05:04 PM, Yuri Nesterenko wrote:
Please take a look at the slightly changed version
of this test-only fix.
Semyon, thank you! I'm sorry I have to update it:
now we have new syntax for addExport; the old syntax
will eventual
Hi Ramesh,
Below are few comments,
General comments :
1. Please provide description about bug cause & how this change fixes the
bug, with the review email.
Also update the bug on JBS with similar analysis.
2. Subject line for review email should in f
Hi Sergey,
In that case we have two options:
Depend on the dispose() method to call removeNotify() on the old popup.
To call the removeNotify() here in this case.
Current implementation depends on the dispose() method to call removeNotify()
on the old popup.
Regards,
Manajit
>
The fix looks good to me.
Thanks,
Alexandr.
On 4/4/2016 9:48 AM, Semyon Sadetsky wrote:
Thank you, Phil.
The updates webrev:
http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.05/
--Semyon
On 3/30/2016 7:22 PM, Phil Race wrote:
> 39 private static final long serialVersionUID
