Review Request For 8129569 : Test java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails

2016-04-13 Thread Ramesh Gangadhar
Hi, Please review fix for bug 8129569 in JDK 9 BUG ID: https://bugs.openjdk.java.net/browse/JDK-8129569 Webrev: http://cr.openjdk.java.net/~jdv/Ramesh/8129569/webrev.00/ Issue: While checking for Frame State when Maximum bounds is set Mac Operating system sets state = Frame.MAXIMIZED

Re: Public RequestFocusController/AWTAccessor API

2016-04-13 Thread Semyon Sadetsky
Hi Reto, It is unlikely that AWTAccessor API may be opened. It gives access to internal undocumented methods not to even mention that those methods have private and package accesses. As I understand you need the way to intercept focus transfer initiated by a traversal key. Why to subclass the

Re: [9] Review Request for 8080395: consider making sun.awt.CausedFocusEvent functionality public

2016-04-13 Thread Philip Race
+1 -phil. On 4/13/16, 11:32 AM, Semyon Sadetsky wrote: The fix was updated with the specification for the class serialization protocol changes which I forget to add: - the new cause field - readResolve() method The updated webrev: http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.06/ --

Re: [9] Review Request for 8080395: consider making sun.awt.CausedFocusEvent functionality public

2016-04-13 Thread Semyon Sadetsky
The fix was updated with the specification for the class serialization protocol changes which I forget to add: - the new cause field - readResolve() method The updated webrev: http://cr.openjdk.java.net/~ssadetsky/8080395/webrev.06/ --Semyon On 4/5/2016 9:48 AM, Semyon Sadetsky wrote: On 4/4

Re: [9] Request for review: JDK-8145984 sun.lwawt.macosx.CAccessible leaks

2016-04-13 Thread Anton Tarasov
Hi Sergey, update: http://cr.openjdk.java.net/~ant/JDK-8145984/jdk8u/webrev.3 > On 12 Apr 2016, at 15:49, Sergey Bylokhov wrote: > > Hi, Anton. > On 10.01.16 13:12, Anton Tarasov wrote: >> >> http://cr.openjdk.java.net/~ant/JDK-814

[9] Review request for JDK-8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X

2016-04-13 Thread Manajit Halder
Hi Prasanta, Could you please push the patch to JDK9 with the following details: http://cr.openjdk.java.net/~aghaisas/manajit/8147841/webrev.01/ 8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X Reviewed-

Re: [9] Review request for JDK-8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X

2016-04-13 Thread Manajit Halder
Hi Sergey and Semyon, Thank you both for the review comments. Thanks, Manajit > On 13-Apr-2016, at 2:01 pm, Semyon Sadetsky > wrote: > > Looks good. > > --Semyon > > On 4/1/2016 1:58 PM, Manajit Halder wrote: >> Hi Sergey, >> >> Thank you for your review comments. The following scenarios

Re: [9] Review request for JDK-8147841: [macosx] Updating TrayIcons popup menu does not work on Mac OS X

2016-04-13 Thread Semyon Sadetsky
Looks good. --Semyon On 4/1/2016 1:58 PM, Manajit Halder wrote: Hi Sergey, Thank you for your review comments. The following scenarios were taken care while modifying the code along with your comments. Case 1) popup and newPopup refers to same object. In cases where the same popup menu is