Re: Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

2016-04-20 Thread Ambarish Rapte
Hi Ramesh The fix looks good. However, could you please check if the test can be run without the 6000 delay. Please arrange the lines to 80 char length. Please remove the System.out.println() calls. Regards, Ambarish From: Ramesh Gangadha

Re: Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-20 Thread Phil Race
On 04/20/2016 12:27 PM, Sergey Bylokhov wrote: 2d-dev added. In fact all these are 2D. No AWT warnings here. I am not sure but why "declaration in the code" is a bad thing and we should fix it? - DISABLED_WARNINGS_solstudio := E_DECLARATION_IN_CODE I cannot find the documentation in sola

Re: Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-20 Thread Sergey Bylokhov
2d-dev added. I am not sure but why "declaration in the code" is a bad thing and we should fix it? - DISABLED_WARNINGS_solstudio := E_DECLARATION_IN_CODE I cannot find the documentation in solaris studio for this warning. On 20.04.16 11:57, Ajit Ghaisas wrote: Hi, Bug : https://bugs.op

Re: Toolkit.createCustomCursor throws exceptions

2016-04-20 Thread Mario Torre
2016-04-20 20:32 GMT+02:00 Sergey Bylokhov : > Hi, Mario. >> >> BTW, Toolkit.createCustomCursor doesn't say to throw anything upon >> failure, I would expect user code to check getBestCursorSize before >> calling createCustomCursor, but this seems to never be done in the >> internal code, and I do

Re: Toolkit.createCustomCursor throws exceptions

2016-04-20 Thread Sergey Bylokhov
Hi, Mario. BTW, Toolkit.createCustomCursor doesn't say to throw anything upon failure, I would expect user code to check getBestCursorSize before calling createCustomCursor, but this seems to never be done in the internal code, and I don't know if we can fix this since it would be a behaviour di

Re: [9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

2016-04-20 Thread Semyon Sadetsky
Hi Manajit, Why robot.keyPress(KeyEvent.VK_ALT_GRAPH) cannot be used to press the right Alt? --Semyon On 4/20/2016 3:16 PM, Manajit Halder wrote: Hi Semyon, Thank you for the review comment. The test can’t be automated because of the following reasons: On Mac OS X and Windows: There is no

Re: Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-20 Thread Erik Joelsson
Build change looks good. /Erik On 2016-04-20 13:30, Ajit Ghaisas wrote: Adding build-dev. -Original Message- From: Ajit Ghaisas Sent: Wednesday, April 20, 2016 2:28 PM To: awt-dev@openjdk.java.net Subject: Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless Hi,

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

2016-04-20 Thread Manajit Halder
Hi Phil, Gentle remainder. Please review the changes. Thanks, Manajit > On 19-Apr-2016, at 2:10 pm, prasanta sadhukhan > wrote: > > Looks ok to me. > > Regards > Prasanta > On 4/19/2016 1:25 PM, Manajit Halder wrote: >> Hi Prasanta, >> >> Thank you for the review comments. Please review the

Re: [9] Review request for JDK-8151136: [macosx] According to the description, the case is failed

2016-04-20 Thread Manajit Halder
Hi Semyon, Thank you for the review comment. The test can’t be automated because of the following reasons: On Mac OS X and Windows: There is no key code for the right ALT button (no right key codes for ALT, SHIFT, COMMAND). robot.keyPress(KeyEvent.VK_ALT) will press the left ALT ke

Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-20 Thread Ajit Ghaisas
Adding build-dev. -Original Message- From: Ajit Ghaisas Sent: Wednesday, April 20, 2016 2:28 PM To: awt-dev@openjdk.java.net Subject: Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-8074829 This bug is to r

Toolkit.createCustomCursor throws exceptions

2016-04-20 Thread Mario Torre
Hi all, I happens that I stumbled upon an interesting issue with XToolkit.createCustomCursor(). On a very specific combination of hardware and X11 driver we get an exception propagating from XToolkit.createCustomCursor(), the exception is: java.awt.AWTException: Exception: class java.lang.Illega

Fix for JDK-8074829 : Resolve disabled warnings for libawt_headless

2016-04-20 Thread Ajit Ghaisas
Hi, Bug : https://bugs.openjdk.java.net/browse/JDK-8074829 This bug is to remove warning suppressions from makefile and fix the warnings for libawt_headless library. I have removed following warning suppressions & fixed the warnings for libawt_headless library. DISABLED_WARN

Re: Review Request For 8129569 : Test java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails

2016-04-20 Thread Ambarish Rapte
Hi Ramesh, Fix looks good to me. Regards, Ambarish From: Ramesh Gangadhar Sent: Tuesday, April 19, 2016 11:10 AM To: awt-dev@openjdk.java.net Subject: Re: Review Request For 8129569 : Test java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails Hello