Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

On 04.05.16 21:13, Anton Tarasov wrote: Anyway, both the JNI locals don’t seem to be left intentionally, but look like a simple misses. Unfortunately (as I wrote during the “CAccessible fix" discussion), PushLocalFrame/PopLocalFrame doesn’t take care of the locals in all the cases. So, a missed

Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

I recall Anton's fix included a couple of unrelated JNI refs that were not being deleted. A separate bug ID would be good for that as it really has nothing to do with this problem at all. -phil. On 5/4/16, 7:08 AM, Sergey Bylokhov wrote: On 04.05.16 16:07, Anton Tarasov wrote: Hi Sergey, As

FW: Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Hi All, This is a Gentle reminder for review. Best Regards, Ramesh BG From: Ramesh Gangadhar Sent: Thursday, April 28, 2016 12:21 To: awt-dev@openjdk.java.net Cc: Ambarish Rapte Subject: RE: Review Request for 8027154: Test

Re: Review request for 8155742 : [Windows] robot.keyPress(KeyEvent.VK_ALT_GRAPH) throws java.lang.IllegalArgumentException in windows

Looks fine. On 03.05.16 19:37, Ambarish Rapte wrote: Hi, Please review fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8155742 Webrev: http://cr.openjdk.java.net/~arapte/8155742/webrev.00/ Issue:

Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

On 04.05.16 16:07, Anton Tarasov wrote: Hi Sergey, As you fixed the surface leak separately (thanks!) should I create a dedicated CR for the unrelated JNI ones? Can you please clarify this case? Do you have a testcase or steps to reproduce?(WindowsLeak.java will pass after the current fix).

Re: [9] Review request for 8080729: [macosx] java 7 and 8 JDialogs on multiscreen jump to parent frame on focus

Hi AWT team, thank you for the great effort in resolving the issue. I tried the fix (webrev.02) with the latest jdk8u-dev repository. I have found the next regressions: 1. Run a test case. JFrame + owned JDialog. Move the frame to the secondary monitor. Move the dialog to the main dialog.

Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

Hi Sergey, As you fixed the surface leak separately (thanks!) should I create a dedicated CR for the unrelated JNI ones? Regards Anton. > On 29 Apr 2016, at 18:19, Sergey Bylokhov wrote: > > On 29.04.16 18:01, Anton Tarasov wrote: >> [CC’ing to 2d-dev to discuss

[9] Push request for 8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac

Hi Semyon, Could you please push the patch to JDK9 with the following details: http://cr.openjdk.java.net/~mhalder/8137137/webrev.02/ 8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac Reviewed-by: psadhukhan, prr

Re: [9] Review request for JDK-8151787 Unify the HiDPI splash screen image naming convention

This fix on Mac OS X looks good to me. > On 02-May-2016, at 2:24 pm, Rajeev Chamyal wrote: > > Updated Webrev link: > > http://cr.openjdk.java.net/~rchamyal/8151787/webrev.04/ > > Regards, > Rajeev Chamyal > > -Original Message- > From: Rajeev Chamyal >