Re: [9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

Hi Manajit, Just a few questions to clarify on the fix. What is difference between AXUIElementPostKeyboardEvent and CGEventCreateKeyboardEvent? Why the latter was commented? Does it mean that valid modifier keys have not been sent by AWT robot? --Semyon On 5/12/2016 10:45 AM, Manajit

Re: RFR: 8154546: Retire sun.misc.GThreadHelper

On 12.05.16 18:36, Philip Race wrote: Think of this fix as really just being about the removal of GThreadHelper since FX was the only one who used it and it no longer uses it and not about implicitly bumping the Java SE requirements. That can be done later if things become more clear. Is that

Re: RFR: 8154546: Retire sun.misc.GThreadHelper

This seems good to me. -- Kevin Philip Race wrote: On 5/12/16, 7:34 AM, Sergey Bylokhov wrote: On 12.05.16 17:23, Philip Race wrote: Probably we should skip the loading of glib >= 2.2 <=2.29 and bump the minumum version to 2.20/2.24? This will eliminate the possibility of the crash. Not

Re: RFR: 8154546: Retire sun.misc.GThreadHelper

On 5/12/16, 7:34 AM, Sergey Bylokhov wrote: On 12.05.16 17:23, Philip Race wrote: Probably we should skip the loading of glib >= 2.2 <=2.29 and bump the minumum version to 2.20/2.24? This will eliminate the possibility of the crash. Not sure what you mean by "skip loading". Where does 2.29

Re: RFR: 8154546: Retire sun.misc.GThreadHelper

On 12.05.16 17:23, Philip Race wrote: Probably we should skip the loading of glib >= 2.2 <=2.29 and bump the minumum version to 2.20/2.24? This will eliminate the possibility of the crash. Not sure what you mean by "skip loading". Where does 2.29 come into this ? typo: I meant 2.20 And

Re: RFR: 8154546: Retire sun.misc.GThreadHelper

On 5/12/16, 3:45 AM, Sergey Bylokhov wrote: On 12.05.16 0:42, Phil Race wrote: Bug: http://cr.openjdk.java.net/~prr/8154546/ Webrev: http://cr.openjdk.java.net/~prr/8154546/ Probably we should skip the loading of glib >= 2.2 <=2.29 and bump the minumum version to 2.20/2.24? This will

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

OK, so +1 -phil On 5/12/16, 12:02 AM, Alexander Scherbatiy wrote: On 12/05/16 03:18, Philip Race wrote: Why doesn't the test need now @modules java.desktop/sun.awt The test does not create a SoftCache or cast to it. It iterates over some object references graph and just skip the case

Review request for 8153184: BorderLayout javadoc says current version of JDK is 1.2

Hi All, Please review the fix for bug 8153184, Webrev: http://cr.openjdk.java.net/~jcm/8153184/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8153184 Issue: It is a documentation bug, it is mentioning version information in the

Re: [8u/9] Review request: JDK-8028486 [TEST_BUG] [macosx] java/awt/Window/WindowsLeak/WindowsLeak.java fails

Hi, Anton, Phil. Do you have some comments about the current version or it can be considered as an approved? On 04.05.16 18:06, Philip Race wrote: I recall Anton's fix included a couple of unrelated JNI refs that were not being deleted. A separate bug ID would be good for that as it really

Re: [9] Review request for 8155001: SystemTray.remove() leaks GDI Objects in Windows

Hello Dmitry Looks good! Thanks alexp On 5/10/2016 13:19, dmitry markov wrote: Hi Sergey, Thank you for the feedback. Actually I am not sure whether such situation, (i.e. m_nid.hIcon is NULL) is possible or not. I think it is better to add null-check there. Please find the updated webrev

Re: RFR: 8154546: Retire sun.misc.GThreadHelper

On 12.05.16 0:42, Phil Race wrote: Bug: http://cr.openjdk.java.net/~prr/8154546/ Webrev: http://cr.openjdk.java.net/~prr/8154546/ Probably we should skip the loading of glib >= 2.2 <=2.29 and bump the minumum version to 2.20/2.24? This will eliminate the possibility of the crash. The

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

On 11 May 2016, at 22:59, Mandy Chung wrote: > >> On May 11, 2016, at 2:55 PM, Alexander Scherbatiy >> wrote: >> >> On 12/05/16 01:50, Phil Race wrote: >>> Alexander ... I am concurrently deleting GThreadHelper (see webrev I just >>>

Re: RFR: 8154546: Retire sun.misc.GThreadHelper

On 11 May 2016, at 22:42, Phil Race wrote: > Bug: http://cr.openjdk.java.net/~prr/8154546/ > Webrev: http://cr.openjdk.java.net/~prr/8154546/ > > The options were move this or delete it. > There is some discussion in the bug report about GLIB versions > but the only

[9] Review request for JDK-8155740: [macosx] robot.keyPress and robot.keyRelease do not generate key event for Alt-Graph key VK_ALT_GRAPH.

Hi All, Kindly review the fix for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8155740 Webrev: http://cr.openjdk.java.net/~mhalder/8155740/webrev.00/ Issue: [macosx]

Re: Review request for 8145284: [Documentation] [TextField] Missing new line character handling

Hi Ambarish, Should we put the doc change at the top or at TextField constructor where you actually made the change for 8055197? My take it should be done in the latter. Also, I think you need a ccc for this. Regards Prasanta On 5/12/2016 12:33 PM, Ambarish Rapte wrote: Hi, Please review

Review request for 8145284: [Documentation] [TextField] Missing new line character handling

Hi, Please review this documentation change for awt.TextField, Bug: https://bugs.openjdk.java.net/browse/JDK-8145284 Webrev: http://cr.openjdk.java.net/~arapte/8145284/webrev.00/ What is the change: After fix of 8055197, TextField replaces

Re: [9] Review request for 8154539 Examine the desktop module's use of sun.misc.SoftCache

On 12/05/16 03:18, Philip Race wrote: Why doesn't the test need now @modules java.desktop/sun.awt The test does not create a SoftCache or cast to it. It iterates over some object references graph and just skip the case where a reference class type name equals to

Re: FW: Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Hi Ramesh, The fix looks fine to me. Regards, Ambarish From: Ramesh Gangadhar Sent: Wednesday, May 04, 2016 8:27 PM To: awt-dev@openjdk.java.net Subject: FW: Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails